Attention is currently required from: Sugnan Prabhu S, Kane Chen, Paul Menzel, Matt Chen, Subrata Banik, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58951 )
Change subject: drivers/wifi/generic: fix package_size to align with WLAN driver
......................................................................
Patch Set 6: Code-Review+2
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58951/comment/a4ada833_9f32dd70
PS3, Line 7: src/drivers/wifi/generic/acpi.c: fix package_size to align with WLAN driver
drivers/wifi/generic
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/58951/comment/3accccae_f172f9d4
PS4, Line 7: drivers/wifi/generic :
OK, will do.
Done
https://review.coreboot.org/c/coreboot/+/58951/comment/6f466b41_34cee136
PS4, Line 11: the WLAN driver check
This Intel WiFi driver, where is in kernel drivers/net/wireless/intel/iwlwifi/fw/acpi.c. […]
Ack
Patchset:
PS6:
@Tim, any comments?
I see, yes, this still does work with what the kernel is expecting for any format. Still, I will file a bug about the proto converter so we can fix it eventually.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18e7d5f658bbf42b7eeed3da330508f14b86c0f8
Gerrit-Change-Number: 58951
Gerrit-PatchSet: 6
Gerrit-Owner: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Janiex Tu
janiex.tu@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.corp-partner.google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Nov 2021 17:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kane Chen
kane.chen@intel.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Matt Chen
matt.chen@intel.corp-partner.google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment