HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46076 )
Change subject: mb/biostar: Convert to ASL 2.0 syntax ......................................................................
mb/biostar: Convert to ASL 2.0 syntax
Change-Id: I122f27bf7e7b809802efdbd443694b3d6e715108 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl M src/mainboard/biostar/am1ml/acpi/sio.asl 2 files changed, 56 insertions(+), 56 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46076/1
diff --git a/src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl b/src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl index a04e298..5ac667d 100644 --- a/src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl +++ b/src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl @@ -19,9 +19,9 @@
Method(WACK, 0) { - Store(0, Local0) - While (LNotEqual(Local0, 0xFA)) { - Store(MRG0, Local0) + Local0 = 0 + While (Local0 != 0xFA) { + Local0 = MRG0 Sleep(10) } } @@ -29,69 +29,69 @@ //Init Method (ITZE, 0) { - Store(0, MRG0) - Store(0xB5, MRG1) - Store(0, MRG2) - Store(0x96, MSTI) + MRG0 = 0 + MRG1 = 0xB5 + MRG2 = 0 + MSTI = 0x96 WACK()
- Store(0, MRG0) - Store(0, MRG1) - Store(0, MRG2) - Store(0x80, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = 0 + MSTI = 0x80 WACK()
- Or(MRG2, 0x01, Local0) + Local0 = MRG2 | 0x01
- Store(0, MRG0) - Store(0, MRG1) - Store(Local0, MRG2) - Store(0x81, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = Local0 + MSTI = 0x81 WACK() }
//Sleep Method (IMSP, 0) { - Store(0, MRG0) - Store(0xB5, MRG1) - Store(0, MRG2) - Store(0x96, MSTI) + MRG0 = 0 + MRG1 = 0xB5 + MRG2 = 0 + MSTI = 0x96 WACK()
- Store(0, MRG0) - Store(1, MRG1) - Store(0, MRG2) - Store(0x98, MSTI) + MRG0 = 0 + MRG1 = 1 + MRG2 = 0 + MSTI = 0x98 WACK()
- Store(0, MRG0) - Store(0xB4, MRG1) - Store(0, MRG2) - Store(0x96, MSTI) + MRG0 = 0 + MRG1 = 0xB4 + MRG2 = 0 + MSTI = 0x96 WACK() }
//Wake Method (IMWK, 0) { - Store(0, MRG0) - Store(0xB5, MRG1) - Store(0, MRG2) - Store(0x96, MSTI) + MRG0 = 0 + MRG1 = 0xB5 + MRG2 = 0 + MSTI = 0x96 WACK()
- Store(0, MRG0) - Store(0, MRG1) - Store(0, MRG2) - Store(0x80, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = 0 + MSTI = 0x80 WACK()
- Or(MRG2, 0x01, Local0) + Local0 = MRG2 | 0x01
- Store(0, MRG0) - Store(0, MRG1) - Store(Local0, MRG2) - Store(0x81, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = Local0 + MSTI = 0x81 WACK() } diff --git a/src/mainboard/biostar/am1ml/acpi/sio.asl b/src/mainboard/biostar/am1ml/acpi/sio.asl index ef0bca5..bf4ff3d 100644 --- a/src/mainboard/biostar/am1ml/acpi/sio.asl +++ b/src/mainboard/biostar/am1ml/acpi/sio.asl @@ -26,17 +26,17 @@ /* Enter the 8728 Config */ Method (EPNP) { - Store(0x87, SIOI) - Store(0x01, SIOI) - Store(0x55, SIOI) - Store(0x55, SIOI) + SIOI = 0x87 + SIOI = 0x01 + SIOI = 0x55 + SIOI = 0x55 }
/* Exit the 8728 Config */ Method (XPNP) { - Store (0x02, SIOI) - Store (0x02, SIOD) + SIOI = 0x02 + SIOD = 0x02 }
/* @@ -46,20 +46,20 @@ Method (SIOS, 1) { /* We only enable KBD PME for S5. */ - If (LLess (Arg0, 0x05)) + If (Arg0 < 0x05) { EPNP() /* DBGO("8728F\n") */ - Store (0x4, LDN) - Store (One, ACTR) /* Enable EC */ + LDN = 0x4 + ACTR = 1 /* Enable EC */ /* - Store (0x4, LDN) - Store (0x04, APC4) + LDN = 0x4 + APC4 = 0x04 */ /* falling edge. which mode? Not sure. */ - Store (0x4, LDN) - Store (0x08, APC1) /* clear PME status, Use 0x18 for mouse & KBD */ - Store (0x4, LDN) - Store (0x08, APC0) /* enable PME, Use 0x18 for mouse & KBD */ + LDN = 0x4 + APC1 = 0x08 /* clear PME status, Use 0x18 for mouse & KBD */ + LDN = 0x4 + APC0 = 0x08 /* enable PME, Use 0x18 for mouse & KBD */ XPNP() } }
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46076
to look at the new patch set (#2).
Change subject: mb/biostar/a68n_5200: Convert to ASL 2.0 syntax ......................................................................
mb/biostar/a68n_5200: Convert to ASL 2.0 syntax
Change-Id: I122f27bf7e7b809802efdbd443694b3d6e715108 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl M src/mainboard/biostar/a68n_5200/acpi/sleep.asl 2 files changed, 45 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46076/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46076
to look at the new patch set (#3).
Change subject: mb/biostar/a68n_5200: Convert to ASL 2.0 syntax ......................................................................
mb/biostar/a68n_5200: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are same.
Change-Id: I122f27bf7e7b809802efdbd443694b3d6e715108 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl M src/mainboard/biostar/a68n_5200/acpi/sleep.asl 2 files changed, 45 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46076/3
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46076 )
Change subject: mb/biostar/a68n_5200: Convert to ASL 2.0 syntax ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl:
https://review.coreboot.org/c/coreboot/+/46076/comment/98ecc60b_c927ccfc PS3, Line 33: 0xB5 mind updating the hex values to coreboot style (lowercase), when already touching them?
Attention is currently required from: Michael Niewöhner. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46076 )
Change subject: mb/biostar/a68n_5200: Convert to ASL 2.0 syntax ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl:
https://review.coreboot.org/c/coreboot/+/46076/comment/56424ff7_1cd5fc45 PS3, Line 33: 0xB5
mind updating the hex values to coreboot style (lowercase), when already touching them?
Done Thx
Attention is currently required from: Michael Niewöhner. Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46076
to look at the new patch set (#4).
Change subject: mb/biostar/a68n_5200: Convert to ASL 2.0 syntax ......................................................................
mb/biostar/a68n_5200: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are same.
Change-Id: I122f27bf7e7b809802efdbd443694b3d6e715108 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl M src/mainboard/biostar/a68n_5200/acpi/sleep.asl 2 files changed, 45 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46076/4
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46076 )
Change subject: mb/biostar/a68n_5200: Convert to ASL 2.0 syntax ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl:
https://review.coreboot.org/c/coreboot/+/46076/comment/06ace6e7_4b2af04f PS4, Line 23: 0xFA one more ;)
Attention is currently required from: Michael Niewöhner. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46076 )
Change subject: mb/biostar/a68n_5200: Convert to ASL 2.0 syntax ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4: Thank you.
File src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl:
https://review.coreboot.org/c/coreboot/+/46076/comment/a9f6903c_427a7f41 PS4, Line 23: 0xFA
one more ;)
Done
Attention is currently required from: Michael Niewöhner. Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46076
to look at the new patch set (#5).
Change subject: mb/biostar/a68n_5200: Convert to ASL 2.0 syntax ......................................................................
mb/biostar/a68n_5200: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are same.
Change-Id: I122f27bf7e7b809802efdbd443694b3d6e715108 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl M src/mainboard/biostar/a68n_5200/acpi/sleep.asl 2 files changed, 45 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46076/5
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46076 )
Change subject: mb/biostar/a68n_5200: Convert to ASL 2.0 syntax ......................................................................
Patch Set 5: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46076 )
Change subject: mb/biostar/a68n_5200: Convert to ASL 2.0 syntax ......................................................................
mb/biostar/a68n_5200: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are same.
Change-Id: I122f27bf7e7b809802efdbd443694b3d6e715108 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46076 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl M src/mainboard/biostar/a68n_5200/acpi/sleep.asl 2 files changed, 45 insertions(+), 45 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl b/src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl index a04e298..4483834 100644 --- a/src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl +++ b/src/mainboard/biostar/a68n_5200/acpi/AmdImc.asl @@ -19,9 +19,9 @@
Method(WACK, 0) { - Store(0, Local0) - While (LNotEqual(Local0, 0xFA)) { - Store(MRG0, Local0) + Local0 = 0 + While (Local0 != 0xfa) { + Local0 = MRG0 Sleep(10) } } @@ -29,69 +29,69 @@ //Init Method (ITZE, 0) { - Store(0, MRG0) - Store(0xB5, MRG1) - Store(0, MRG2) - Store(0x96, MSTI) + MRG0 = 0 + MRG1 = 0xb5 + MRG2 = 0 + MSTI = 0x96 WACK()
- Store(0, MRG0) - Store(0, MRG1) - Store(0, MRG2) - Store(0x80, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = 0 + MSTI = 0x80 WACK()
- Or(MRG2, 0x01, Local0) + Local0 = MRG2 | 0x01
- Store(0, MRG0) - Store(0, MRG1) - Store(Local0, MRG2) - Store(0x81, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = Local0 + MSTI = 0x81 WACK() }
//Sleep Method (IMSP, 0) { - Store(0, MRG0) - Store(0xB5, MRG1) - Store(0, MRG2) - Store(0x96, MSTI) + MRG0 = 0 + MRG1 = 0xb5 + MRG2 = 0 + MSTI = 0x96 WACK()
- Store(0, MRG0) - Store(1, MRG1) - Store(0, MRG2) - Store(0x98, MSTI) + MRG0 = 0 + MRG1 = 1 + MRG2 = 0 + MSTI = 0x98 WACK()
- Store(0, MRG0) - Store(0xB4, MRG1) - Store(0, MRG2) - Store(0x96, MSTI) + MRG0 = 0 + MRG1 = 0xb4 + MRG2 = 0 + MSTI = 0x96 WACK() }
//Wake Method (IMWK, 0) { - Store(0, MRG0) - Store(0xB5, MRG1) - Store(0, MRG2) - Store(0x96, MSTI) + MRG0 = 0 + MRG1 = 0xb5 + MRG2 = 0 + MSTI = 0x96 WACK()
- Store(0, MRG0) - Store(0, MRG1) - Store(0, MRG2) - Store(0x80, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = 0 + MSTI = 0x80 WACK()
- Or(MRG2, 0x01, Local0) + Local0 = MRG2 | 0x01
- Store(0, MRG0) - Store(0, MRG1) - Store(Local0, MRG2) - Store(0x81, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = Local0 + MSTI = 0x81 WACK() } diff --git a/src/mainboard/biostar/a68n_5200/acpi/sleep.asl b/src/mainboard/biostar/a68n_5200/acpi/sleep.asl index 47dd146..fc26c30 100644 --- a/src/mainboard/biostar/a68n_5200/acpi/sleep.asl +++ b/src/mainboard/biostar/a68n_5200/acpi/sleep.asl @@ -30,9 +30,9 @@ /* DBGO("\n") */
/* Clear wake status structure. */ - Store(0, Index(WKST,0)) - Store(0, Index(WKST,1)) - Store(7, UPWS) + WKST [0] = 0 + WKST [1] = 0 + UPWS = 7 _SB.APTS(Arg0) } /* End Method(_PTS) */
@@ -56,7 +56,7 @@ /* DBGO("From S") */ /* DBGO(Arg0) */ /* DBGO(" to S0\n") */ - Store(1,USBS) + USBS = 1
_SB.AWAK(Arg0)
-
HAOUAS Elyes (Code Review) -
Michael Niewöhner (Code Review)