Change in ...coreboot[master]: console/post.c: Fix variable 'extra' set but not used

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32995

Change subject: console/post.c: Fix variable 'extra' set but not used
......................................................................

console/post.c: Fix variable 'extra' set but not used

Change-Id: I678d62e78184a4bf99876df0bb96d6e05eacaf50
Signed-off-by: Elyes HAOUAS 
---
M src/console/post.c
1 file changed, 4 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/32995/1

diff --git a/src/console/post.c b/src/console/post.c
index 0719e5e..c7dada2 100644
--- a/src/console/post.c
+++ b/src/console/post.c
@@ -47,9 +47,7 @@
 void cmos_post_log(void)
 {
    u8 code = 0;
-#if CONFIG(CMOS_POST_EXTRA)
    u32 extra = 0;
-#endif

spin_lock(&cmos_post_lock);

@@ -57,15 +55,13 @@
    switch (cmos_read(CMOS_POST_BANK_OFFSET)) {
    case CMOS_POST_BANK_0_MAGIC:
    	code = cmos_read(CMOS_POST_BANK_1_OFFSET);
-#if CONFIG(CMOS_POST_EXTRA)
-		extra = cmos_read32(CMOS_POST_BANK_1_EXTRA);
-#endif
+		if CONFIG(CMOS_POST_EXTRA)
+			extra = cmos_read32(CMOS_POST_BANK_1_EXTRA);
    	break;
    case CMOS_POST_BANK_1_MAGIC:
    	code = cmos_read(CMOS_POST_BANK_0_OFFSET);
-#if CONFIG(CMOS_POST_EXTRA)
-		extra = cmos_read32(CMOS_POST_BANK_0_EXTRA);
-#endif
+		if CONFIG(CMOS_POST_EXTRA)
+			extra = cmos_read32(CMOS_POST_BANK_0_EXTRA);
    	break;
    }

@@ -83,11 +79,9 @@
    	       "in previous boot: 0x%02x\n", code);
 #if CONFIG(ELOG) && (ENV_RAMSTAGE || CONFIG(ELOG_PRERAM))
    	elog_add_event_word(ELOG_TYPE_LAST_POST_CODE, code);
-#if CONFIG(CMOS_POST_EXTRA)
    	if (extra)
    		elog_add_event_dword(ELOG_TYPE_POST_EXTRA, extra);
 #endif
-#endif
    }
 }

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32995 )

Change subject: console/post.c: Fix variable 'extra' set but not used
......................................................................

Abandoned