Change in coreboot[master]: [UNTESTED] soc/intel/{icl,tgl,jsl,ehl}: PM ACPI timer state from Kconfig
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45957 )
Change subject: [UNTESTED] soc/intel/{icl,tgl,jsl,ehl}: PM ACPI timer state from Kconfig ......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45957/21//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45957/21//COMMIT_MSG@9 PS21, Line 9: devicetree
Kconfig?
Ack
https://review.coreboot.org/c/coreboot/+/45957/21/src/soc/intel/elkhartlake/... File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45957/21/src/soc/intel/elkhartlake/... PS21, Line 64: /* PM ACPI timer */
I’d remove the redundent comment, or add a reference to the requirement (datasheet, spec).
hmm, isn't "Override/Fill FSP Silicon Param for mainboard" for `mainboard_silicon_init_params` redundant, too?
-
Michael Niewöhner (Code Review)