Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34154 )
Change subject: cpu/x86: Remove obsolete smm_init_completion() ......................................................................
cpu/x86: Remove obsolete smm_init_completion()
This is not used together with PARALLEL_MP and SMM_TSEG. Platforms with SMM_ASEG continue to have their local implementation doing the same thing.
Change-Id: I13a2f164804330c93240bff7f048e0a162b3ae25 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/intel/smm/gen1/smmrelocate.c 1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/34154/1
diff --git a/src/cpu/intel/smm/gen1/smmrelocate.c b/src/cpu/intel/smm/gen1/smmrelocate.c index d52043f..986929c 100644 --- a/src/cpu/intel/smm/gen1/smmrelocate.c +++ b/src/cpu/intel/smm/gen1/smmrelocate.c @@ -57,7 +57,6 @@
/* This gets filled in and used during relocation. */ static struct smm_relocation_params smm_reloc_params; -static void *default_smm_area = NULL;
/* On model_6fx, model_1067x and model_106cx SMRR functions slightly differently. The MSR are at different location from the rest @@ -168,11 +167,6 @@ memset(ied_base + (1 << 20), 0, (32 << 10)); }
-void smm_init_completion(void) -{ - restore_default_smm_area(default_smm_area); -} - void smm_lock(void) { /* LOCK the SMM memory window and enable normal SMM.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34154 )
Change subject: cpu/x86: Remove obsolete smm_init_completion() ......................................................................
Patch Set 2: Code-Review+1
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34154 )
Change subject: cpu/x86: Remove obsolete smm_init_completion() ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34154 )
Change subject: cpu/x86: Remove obsolete smm_init_completion() ......................................................................
cpu/x86: Remove obsolete smm_init_completion()
This is not used together with PARALLEL_MP and SMM_TSEG. Platforms with SMM_ASEG continue to have their local implementation doing the same thing.
Change-Id: I13a2f164804330c93240bff7f048e0a162b3ae25 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34154 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/intel/smm/gen1/smmrelocate.c 1 file changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
diff --git a/src/cpu/intel/smm/gen1/smmrelocate.c b/src/cpu/intel/smm/gen1/smmrelocate.c index d52043f..986929c 100644 --- a/src/cpu/intel/smm/gen1/smmrelocate.c +++ b/src/cpu/intel/smm/gen1/smmrelocate.c @@ -57,7 +57,6 @@
/* This gets filled in and used during relocation. */ static struct smm_relocation_params smm_reloc_params; -static void *default_smm_area = NULL;
/* On model_6fx, model_1067x and model_106cx SMRR functions slightly differently. The MSR are at different location from the rest @@ -168,11 +167,6 @@ memset(ied_base + (1 << 20), 0, (32 << 10)); }
-void smm_init_completion(void) -{ - restore_default_smm_area(default_smm_area); -} - void smm_lock(void) { /* LOCK the SMM memory window and enable normal SMM.
-
Arthur Heymans (Code Review) -
Kyösti Mälkki (Code Review)
-
Paul Menzel (Code Review)