Attention is currently required from: Angel Pons, Cliff Huang, Lance Zhao, Maximilian Brune, Naresh Solanki, Nico Huber, Patrick Rudolph, Paul Menzel, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78115?usp=email )
Change subject: acpi/acpi_gic: Add GIC ITS subtable
......................................................................
Patch Set 4:
(3 comments)
File src/acpi/acpi_gic.c:
https://review.coreboot.org/c/coreboot/+/78115/comment/f45204c6_7452fe18 :
PS4, Line 85: }
Is this weak implementation necessary? The other platform_*() functions
above don't have one.
Would it make sense to the ITS to the devicetree and just loop over them?
https://review.coreboot.org/c/coreboot/+/78115/comment/1a871698_9313498d :
PS4, Line 99: its_base + (i * its_size);
This API is strange and possibly not sufficiently generic. It looks like the its_size is just there for some SOC specific alignment or spacing between ITS, but it still assumes that they are placed sequentially in memory. Why not pass an array of bases in platform_get_gic_its and their count?
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/78115/comment/7add6a4d_457d8851 :
PS4, Line 1600: uintptr_t
size_t
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78115?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1bcb3ad24de64cbba8aeef7ba7254d3157e0dc43
Gerrit-Change-Number: 78115
Gerrit-PatchSet: 4
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Comment-Date: Fri, 24 Nov 2023 20:24:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment