[S] Change in coreboot[master]: libpayload: Fix compiler warnings - coreboot-gerrit

22 Nov 2022


      Attention is currently required from: Thomas Heijligen.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69764 )
Change subject: libpayload: Fix compiler warnings
......................................................................
Patch Set 4:
(1 comment)
File payloads/libpayload/drivers/serial/8250.c:
https://review.coreboot.org/c/coreboot/+/69764/comment/e947d13d_6ca78af4 
PS4, Line 75: #if !CONFIG(LP_PL011_SERIAL_CONSOLE)
i wonder if a if (CONFIG(LP_PL011_SERIAL_CONSOLE)) return; would be an alternative to using the preprocessor here
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69764
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id285c24cba790f181fa203f3117e5df35bed27c4
Gerrit-Change-Number: 69764
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Tue, 22 Nov 2022 12:36:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment