Attention is currently required from: Frank Wu, John Su, Dtrain Hsu, Jason Nien, Jon Murphy, Chris Wang, Martin Roth, Karthik Ramasubramanian.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73081 )
Change subject: mb/google/skyrim/var/frostflow: Update DPTC and STT settings
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/skyrim/variants/frostflow/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/73081/comment/66a9d94b_6268dde3
PS4, Line 159: register "stt_alpha_apu" = "0x4ccd"
: register "stt_error_coeff" = "0x21"
: register "stt_error_rate_coefficient" = "0x2666"
These values are not being set in `src/third_party/coreboot/src/soc/amd/mendocino/root_complex.c`.
They need to be added to `src/third_party/coreboot/src/soc/amd/common/block/include/amdblocks/alib.h` and the macro `DPTC_INPUTS`. AMD doc #55483 has the offset values.
Default vaules will need to be added to `src/third_party/coreboot/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb`, so every board has them set by `DPTC_INPUTS`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73081
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7df3f9bfa3f0e1337c502bc7db9e09e12cd956a
Gerrit-Change-Number: 73081
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Chao Gui
chaogui@google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 21 Feb 2023 18:19:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment