Change in coreboot[master]: soc/intel/tigerlake: Replace soc_get_pmc_mux_device with device pointers
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45747 )
Change subject: soc/intel/tigerlake: Replace soc_get_pmc_mux_device with device pointers ......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45747/8/src/ec/google/chromeec/ec_a... File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/45747/8/src/ec/google/chromeec/ec_a... PS8, Line 138: for (i = 0; i < num_ports; ++i) {
I'm not sure if we should bail or attempt to write as much as we know about, I'm inclined to think w […]
It's okay to write as much as we can as long as we can guarantee that: 1. downstream code doesn't end up doing something weird 2. kernel won't be unhappy
But, I think we should at least have an ERROR print since that will be caught either by developers or tests.
-
Furquan Shaikh (Code Review)