Attention is currently required from: Ian Feng, Jayvik Desai, Kapil Porwal, Pranava Y N.
Subrata Banik has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/86413?usp=email )
Change subject: mb/google/fatcat/var/francka: Configure the finger print pins
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/fatcat/variants/francka/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/86413/comment/609ddd59_745a7fab?usp... :
PS1, Line 66: PchSerialIoDisabled
I disable GSPI0 PCI mode and fingerprint(GSPI1) functions still work well.
Do I need to enable PCI mode of GPIO0?
please ignore my comments, GSPI0 is not the first device in the PCI bus so, my recommendation is not valid
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86413?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0d9b1d042da1bd81d0f3a32140247948cdab983c
Gerrit-Change-Number: 86413
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Fri, 14 Feb 2025 13:33:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ian Feng
ian_feng@compal.corp-partner.google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com