Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45951 )
Change subject: soc/intel: deduplicate ACPI timer emulation ......................................................................
Patch Set 17: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/45951/17/src/soc/intel/alderlake/cp... File src/soc/intel/alderlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/45951/17/src/soc/intel/alderlake/cp... PS17, Line 148: if ACPI PM timer is disabled Will need in update if we decide to drop the condition.
https://review.coreboot.org/c/coreboot/+/45951/17/src/soc/intel/apollolake/M... File src/soc/intel/apollolake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45951/17/src/soc/intel/apollolake/M... PS17, Line 13: ../../soc/intel/ How about removing a bit of the rendundant path? :)
https://review.coreboot.org/c/coreboot/+/45951/17/src/soc/intel/common/block... File src/soc/intel/common/block/cpu/pm_timer_emulation.c:
https://review.coreboot.org/c/coreboot/+/45951/17/src/soc/intel/common/block... PS17, Line 26: msr.lo = (EMULATE_DELAY_VALUE << EMULATE_DELAY_OFFSET_VALUE) | Not all versions set this value, are we sure about it?
-
Nico Huber (Code Review)