Hello Pratikkumar V Prajapati, Subrata Banik, Tim Wawrzynczak, Shelley Chen, V Sowmya, build bot (Jenkins), Furquan Shaikh,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/38324
to review the following change.
Change subject: Revert "mb/google/hatch: Override CPU flex ratio" ......................................................................
Revert "mb/google/hatch: Override CPU flex ratio"
This reverts commit a017e5fb3dda5ea6bbc94ee15b2e981eeaa2d918.
Reason for revert: The extra reset in the FSP after the flex ratio is changed causes recovery reasons to be lost. There are some vboot changes that recently landed that could help with this issue, but for now, we are working on a new AU image for Kohaku and this is causing our automated testing to fail.
Change-Id: Ic38b390842e2a533033587b3247b7c8d982b1dff --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/38324/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index e0291bb..b4d7afd 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -194,9 +194,6 @@ register "gpio_pm[COMM_3]" = "0" register "gpio_pm[COMM_4]" = "0"
- # CPU Ratio Override - register "cpu_ratio_override" = "15" - # chipset_lockdown configuration # Use below format to override value in overridetree.cb if required # format:
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38324 )
Change subject: Revert "mb/google/hatch: Override CPU flex ratio" ......................................................................
Patch Set 1: Code-Review+2
Hello Pratikkumar V Prajapati, Subrata Banik, Tim Wawrzynczak, Shelley Chen, V Sowmya, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38324
to look at the new patch set (#2).
Change subject: Revert "mb/google/hatch: Override CPU flex ratio" ......................................................................
Revert "mb/google/hatch: Override CPU flex ratio"
This reverts commit a017e5fb3dda5ea6bbc94ee15b2e981eeaa2d918.
Reason for revert: The extra reset in the FSP after the flex ratio is changed causes recovery reasons to be lost. There are some vboot changes that recently landed that could help with this issue, but for now, we are working on a new AU image for Kohaku and this is causing our automated testing to fail.
Change-Id: Ic38b390842e2a533033587b3247b7c8d982b1dff Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/38324/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38324 )
Change subject: Revert "mb/google/hatch: Override CPU flex ratio" ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38324 )
Change subject: Revert "mb/google/hatch: Override CPU flex ratio" ......................................................................
Revert "mb/google/hatch: Override CPU flex ratio"
This reverts commit a017e5fb3dda5ea6bbc94ee15b2e981eeaa2d918.
Reason for revert: The extra reset in the FSP after the flex ratio is changed causes recovery reasons to be lost. There are some vboot changes that recently landed that could help with this issue, but for now, we are working on a new AU image for Kohaku and this is causing our automated testing to fail.
Change-Id: Ic38b390842e2a533033587b3247b7c8d982b1dff Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/38324 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index f7cf3cd..9894e56 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -197,9 +197,6 @@ register "gpio_pm[COMM_3]" = "0" register "gpio_pm[COMM_4]" = "0"
- # CPU Ratio Override - register "cpu_ratio_override" = "15" - # chipset_lockdown configuration # Use below format to override value in overridetree.cb if required # format:
-
Patrick Georgi (Code Review) -
Tim Wawrzynczak (Code Review)