[L] Change in coreboot[main]: device/device.h: Rename busses for clarity - coreboot-gerrit

30 Jan 2024


      Attention is currently required from: Angel Pons, Caveh Jalali, Chen, Gang C, Christian Walter, Cliff Huang, Dinesh Gehlot, Eran Mitrani, Eric Lai, Felix Held, Forest Mittelberg, Fred Reitberger, Jakub Czapiga, Jason Glenesk, Jason Nien, Jeff Daly, Jincheng Li, Johnny Lin, Jérémy Compostella, Kapil Porwal, Lance Zhao, Martin L Roth, Martin Roth, Matt DeVillier, Michał Żygowski, Nick Vaccaro, Piotr Król, Sean Rhodes, Shuo Liu, Subrata Banik, Tarun, Tim Chu, Tim Wawrzynczak, Vanessa Eusebio, Varshit Pandya, Werner Zeh.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78330?usp=email )
Change subject: device/device.h: Rename busses for clarity
......................................................................
Patch Set 25: -Code-Review
(1 comment)
File src/device/root_device.c:
https://review.coreboot.org/c/coreboot/+/78330/comment/f7d94b79_c1f1c56d :
PS24, Line 89: if (dev_root.downstream)
             : 		scan_bridges(bus->downstream);
...
culprit...
Done. Things work fine now
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78330?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80a81b6b8606e450ff180add9439481ec28c2420
Gerrit-Change-Number: 78330
Gerrit-PatchSet: 25
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Chen, Gang C gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Eran Mitrani mitrani@google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Forest Mittelberg bmbm@google.com
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jakub Czapiga czapiga@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jeff Daly jeffd@silicom-usa.com
Gerrit-Reviewer: Jincheng Li jincheng.li@intel.com
Gerrit-Reviewer: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Shuo Liu shuo.liu@intel.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun tstuli@gmail.com
Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Varshit Pandya pandyavarshit@gmail.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Eran Mitrani mitrani@google.com
Gerrit-Attention: Jakub Czapiga czapiga@google.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Piotr Król piotr.krol@3mdeb.com
Gerrit-Attention: Varshit Pandya pandyavarshit@gmail.com
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Caveh Jalali caveh@chromium.org
Gerrit-Attention: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Tim Chu Tim.Chu@quantatw.com
Gerrit-Attention: Eric Lai ericllai@google.com
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Attention: Jeff Daly jeffd@silicom-usa.com
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tarun tstuli@gmail.com
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Chen, Gang C gang.c.chen@intel.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Attention: Shuo Liu shuo.liu@intel.com
Gerrit-Attention: Jincheng Li jincheng.li@intel.com
Gerrit-Attention: Forest Mittelberg bmbm@google.com
Gerrit-Comment-Date: Tue, 30 Jan 2024 10:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment