Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45886 )
Change subject: lib/spd_bin: add LPDDR4X case to spd_get_name() ......................................................................
lib/spd_bin: add LPDDR4X case to spd_get_name()
Add case for LPDDR4x to spd_get_name().
BUG=b:169800932, b:168724473 TEST=none
Change-Id: I6bae373468b8ad5ae0a6b8dd6bbe14143afb85af Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/lib/spd_bin.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/45886/1
diff --git a/src/lib/spd_bin.c b/src/lib/spd_bin.c index 3888896..d14fd97 100644 --- a/src/lib/spd_bin.c +++ b/src/lib/spd_bin.c @@ -152,6 +152,7 @@ case SPD_DRAM_LPDDR3_JEDEC: case SPD_DRAM_DDR4: case SPD_DRAM_LPDDR4: + case SPD_DRAM_LPDDR4X: memcpy(spd_name, &spd[DDR4_SPD_PART_OFF], DDR4_SPD_PART_LEN); spd_name[DDR4_SPD_PART_LEN] = 0; break;
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45886 )
Change subject: lib/spd_bin: add LPDDR4X case to spd_get_name() ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Caveh Jalali,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45886
to look at the new patch set (#5).
Change subject: lib/spd_bin: add LPDDR4X case to spd_get_name() ......................................................................
lib/spd_bin: add LPDDR4X case to spd_get_name()
Add case for LPDDR4x to spd_get_name().
BUG=b:169800932, b:168724473 TEST=none
Change-Id: I6bae373468b8ad5ae0a6b8dd6bbe14143afb85af Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/lib/spd_bin.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/45886/5
Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45886 )
Change subject: lib/spd_bin: add LPDDR4X case to spd_get_name() ......................................................................
lib/spd_bin: add LPDDR4X case to spd_get_name()
Add case for LPDDR4x to spd_get_name().
BUG=b:169800932, b:168724473 TEST=none
Change-Id: I6bae373468b8ad5ae0a6b8dd6bbe14143afb85af Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45886 Reviewed-by: Caveh Jalali caveh@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/lib/spd_bin.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved
diff --git a/src/lib/spd_bin.c b/src/lib/spd_bin.c index aeed204..4125973 100644 --- a/src/lib/spd_bin.c +++ b/src/lib/spd_bin.c @@ -159,6 +159,7 @@ case SPD_DRAM_LPDDR3_JEDEC: case SPD_DRAM_DDR4: case SPD_DRAM_LPDDR4: + case SPD_DRAM_LPDDR4X: memcpy(spd_name, &spd[DDR4_SPD_PART_OFF], DDR4_SPD_PART_LEN); spd_name[DDR4_SPD_PART_LEN] = 0; break;
-
Caveh Jalali (Code Review) -
Nick Vaccaro (Code Review)