Attention is currently required from: Guangjie Song, Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84495?usp=email )
Change subject: soc/mediatek/mt8196: Add PLL and Clock init support
......................................................................
Patch Set 26:
(2 comments)
File src/soc/mediatek/mt8196/pll.c:
https://review.coreboot.org/c/coreboot/+/84495/comment/ebf3f828_293d31f5?usp... :
PS13, Line 1196: 30
Alternatively, most of the `mtcmos_idx` values are `PM_DUMMY1`. Can we store only the two entries […]
Agree with Yu-Ping. We can default set `cg_idx` 0 ~ 49 to`PM_DUMMY1` and subsequently set above two entries.
File src/soc/mediatek/mt8196/pll.c:
https://review.coreboot.org/c/coreboot/+/84495/comment/8e2b1ba3_7e8d5bc8?usp... :
PS26, Line 1176: mmvote_mtcmos_mtcmos_table
`child_idx` is the same as `parent_idx`. Is is expected ? Can we just keep either one ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84495?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icac99fb210c87c8b7b14af627fbd2f14e4c47240
Gerrit-Change-Number: 84495
Gerrit-PatchSet: 26
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Guangjie Song
guangjie.song@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Guangjie Song
guangjie.song@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Mon, 04 Nov 2024 02:48:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Guangjie Song
guangjie.song@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Jarried Lin
jarried.lin@mediatek.com