Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/86390?usp=email )
Change subject: sb/intel/common: Add GPIO serial blink console support
......................................................................
Patch Set 1:
(1 comment)
File src/southbridge/intel/common/gpio.c:
https://review.coreboot.org/c/coreboot/+/86390/comment/f91b111f_60598c8f?usp... :
PS1, Line 195: CONSOLE_INTEL_GPSB)
Couldn't in its own C file instead ?
Because static get_gpio_base(). To put this code in its own file I'll need to make it not static and set up headers accordingly. If that's ok I'll do it.
Also, once factored out should it live in console/ or sb/intel/common?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86390?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0741142fe21eba4989d28b96e795d3bfa3085466
Gerrit-Change-Number: 86390
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Fri, 14 Feb 2025 02:27:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com