Attention is currently required from: Jeremy Soller, Paul Menzel.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80756?usp=email )
Change subject: mb/system76/adl,rpl: Add FSP default timeout for PCIe 3.0 RPs
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80756/comment/c92ebe75_3060cf93 :
PS1, Line 15:
Changed to use FSP default of 56ms.
I actually misread the FSP UPD. It doesn't set this, so the value is arbitrary. 50ms is a lot, but I'm not going to figure out how low I can make it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80756?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f44fc429c52e407b7566d6bb6dd31b2cf85c48d
Gerrit-Change-Number: 80756
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 29 Feb 2024 18:36:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford
tcrawford@system76.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment