Change in coreboot[master]: soc/intel/tigerlake: Configure ClkReq according to mainboard design
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38285 )
Change subject: soc/intel/tigerlake: Configure ClkReq according to mainboard design ......................................................................
Patch Set 8: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/38285/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38285/6//COMMIT_MSG@7 PS6, Line 7: Support NVMe boot
This is not really correct. […]
Ack
https://review.coreboot.org/c/coreboot/+/38285/6/src/soc/intel/tigerlake/rom... File src/soc/intel/tigerlake/romstage/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/38285/6/src/soc/intel/tigerlake/rom... PS6, Line 64: sizeof(config->PcieClkSrcClkReq));
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38285/6/src/soc/intel/tigerlake/rom... PS6, Line 64: sizeof(config->PcieClkSrcClkReq));
code indent should use tabs where possible
Ack
-
Wonkyu Kim (Code Review)