HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25600 )
Change subject: nb/intel/i945: Use parallel MP init ......................................................................
Patch Set 37:
(4 comments)
https://review.coreboot.org/#/c/25600/37/src/cpu/intel/model_f3x/model_f3x_i... File src/cpu/intel/model_f3x/model_f3x_init.c:
https://review.coreboot.org/#/c/25600/37/src/cpu/intel/model_f3x/model_f3x_i... PS37, Line 16: #include <cpu/x86/mtrr.h> to remove ?
https://review.coreboot.org/#/c/25600/37/src/cpu/intel/model_f3x/model_f3x_i... PS37, Line 18: #include <cpu/intel/microcode.h> : #include <cpu/intel/hyperthreading.h> maybe to remove
https://review.coreboot.org/#/c/25600/37/src/cpu/intel/model_f3x/model_f3x_i... PS37, Line 27: if (!IS_ENABLED(CONFIG_PARALLEL_MP) && !intel_ht_sibling()) { : /* MTRRs are shared between threads */ : x86_setup_mtrrs(); : x86_mtrr_check(); : : /* Update the microcode */ : intel_update_microcode_from_cbfs(); : } maybe to remove ?
https://review.coreboot.org/#/c/25600/37/src/cpu/intel/model_f3x/model_f3x_i... PS37, Line 39: /* Start up my CPU siblings */ : if (!IS_ENABLED(CONFIG_PARALLEL_MP)) : intel_sibling_init(cpu); this one also to remove?