Attention is currently required from: Hung-Te Lin.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85861?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/common/dp: Move common functions to dptx_hal_common.c ......................................................................
Patch Set 7:
(1 comment)
File src/soc/mediatek/common/dp/dptx_hal.c:
https://review.coreboot.org/c/coreboot/+/85861/comment/dbcf701f_ba263c31?usp... : PS3, Line 79: vsync Check with MTK, `dptx_hal_set_msa` can be shared with MT8196. The differences on MT8196 are wrong settings. We also found that the setting here is not correct. It should be `hsync` instead of vsync. I will find a Ciri to verify the settings.