Attention is currently required from: Arthur Heymans, Felix Held, Martin L Roth, Martin Roth.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76506?usp=email )
Change subject: soc/amd/genoa: Add aoac.c & enable AOAC devices early
......................................................................
Patch Set 9:
(3 comments)
File src/soc/amd/genoa/aoac.c:
https://review.coreboot.org/c/coreboot/+/76506/comment/5d5418e1_73ee03c9 :
PS4, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Note that this file no longer exists in the preceding commits, so this patch needs to be rebased man […]
Done
https://review.coreboot.org/c/coreboot/+/76506/comment/2cac664a_0304bff6 :
PS4, Line 12: : CONFIG_UART_FOR_CONSOLE == 1 ? FCH_AOAC_DEV_UART1 \
uart2 is missing here
Done
File src/soc/amd/genoa/include/soc/aoac_defs.h:
https://review.coreboot.org/c/coreboot/+/76506/comment/cf8463ba_f2c7921b :
PS7, Line 17: #define FCH_AOAC_DEV_UART3 26
: #define FCH_AOAC_DEV_UART4 20
does genoa have uart3 and 4? from the devicetree i'd assume that it has only uarts 0.. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76506?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic9553e6016c92c9b1678c395cd6a9e6860bf8a76
Gerrit-Change-Number: 76506
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 04 Oct 2023 15:10:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment