Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38838 )
Change subject: cpu: Add initial xeonsp support broilerplate ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38838/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38838/2//COMMIT_MSG@7 PS2, Line 7: broilerplate
Very likely.
Done
https://review.coreboot.org/c/coreboot/+/38838/2//COMMIT_MSG@9 PS2, Line 9: broilerplate
same here
Done
https://review.coreboot.org/c/coreboot/+/38838/2//COMMIT_MSG@10 PS2, Line 10: xeonsp
Xeon SP […]
I like xeon_scalable more than xeonsp, thanks. I will not change the name just yet -- lets see if we will have other variants as well.
The idea behind this patch is to add generic platform code that would be useful by multiple Xeon, uh, "platforms".
The wrinkle with it that you can have a mainboard that can support skylake-sp and cascadelake-sp or icelake-something. Several of CPUs are actually pin-compatible.
https://review.coreboot.org/c/coreboot/+/38838/2//COMMIT_MSG@14 PS2, Line 14: Change-Id: I24346b8a5c30342419db23b5f1adf27d4d0ebc5f
Missing Signed-off-by line.
Done
-
Andrey Petrov (Code Review)