Change in coreboot[master]: mb/google/volteer/var/halvor: Update TBT2 setting for Halvor

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Frank Wu (Code Review)

25 Aug 2020 25 Aug '20

4:44 a.m.

Frank Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44747 )

Change subject: mb/google/volteer/var/halvor: Update TBT2 setting for Halvor ......................................................................

mb/google/volteer/var/halvor: Update TBT2 setting for Halvor

Enable TBT2 setting in overridetree.cb based on schematic.

BUG=b:165175296, b:166060548 BRANCH=none TEST=Check all USB ports USB2 and USB3 both functional

Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I23ecf76a3c2f631211b0ae2898707c68862b374b --- M src/mainboard/google/volteer/variants/halvor/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/44747/1

diff --git a/src/mainboard/google/volteer/variants/halvor/overridetree.cb b/src/mainboard/google/volteer/variants/halvor/overridetree.cb index 2db3b96..2ef2e42 100644 --- a/src/mainboard/google/volteer/variants/halvor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/halvor/overridetree.cb @@ -19,6 +19,7 @@

device domain 0 on device pci 07.2 on end # TBT_PCIe2 + device pci 0d.3 on end # TBT DMA1 0x9A1D device pci 15.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

EricR Lai (Code Review)

25 Aug 25 Aug

5:17 a.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44747 )

Change subject: mb/google/volteer/var/halvor: Update TBT2 setting for Halvor ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23ecf76a3c2f631211b0ae2898707c68862b374b Gerrit-Change-Number: 44747 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Amanda Hwang amanda_hwang@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 25 Aug 2020 05:17:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

3:27 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44747 )

Change subject: mb/google/volteer/var/halvor: Update TBT2 setting for Halvor ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/44747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23ecf76a3c2f631211b0ae2898707c68862b374b Gerrit-Change-Number: 44747 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Amanda Hwang amanda_hwang@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 25 Aug 2020 15:27:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

31 Aug 31 Aug

6:27 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44747 )

Change subject: mb/google/volteer/var/halvor: Update TBT2 setting for Halvor ......................................................................

mb/google/volteer/var/halvor: Update TBT2 setting for Halvor

Enable TBT2 setting in overridetree.cb based on schematic.

BUG=b:165175296, b:166060548 BRANCH=none TEST=Check all USB ports USB2 and USB3 both functional

Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I23ecf76a3c2f631211b0ae2898707c68862b374b Reviewed-on: https://review.coreboot.org/c/coreboot/+/44747 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org --- M src/mainboard/google/volteer/variants/halvor/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve

device domain 0 on device pci 07.2 on end # TBT_PCIe2 + device pci 0d.3 on end # TBT DMA1 0x9A1D device pci 15.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""

-- To view, visit https://review.coreboot.org/c/coreboot/+/44747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23ecf76a3c2f631211b0ae2898707c68862b374b Gerrit-Change-Number: 44747 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Amanda Hwang amanda_hwang@compal.corp-partner.google.com Gerrit-MessageType: merged

9elements QA (Code Review)

7:45 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44747 )

Change subject: mb/google/volteer/var/halvor: Update TBT2 setting for Halvor ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 6/1/7 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17188 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17187 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/17186 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17185 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/17184 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17190 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17189

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/44747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23ecf76a3c2f631211b0ae2898707c68862b374b Gerrit-Change-Number: 44747 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Amanda Hwang amanda_hwang@compal.corp-partner.google.com Gerrit-Comment-Date: Mon, 31 Aug 2020 07:45:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1576

days inactive

1582

days old

coreboot-gerrit@coreboot.org

4 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
EricR Lai (Code Review)
Frank Wu (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)