Attention is currently required from: Angel Pons, Arthur Heymans, Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78088?usp=email )
Change subject: sb/intel/common/smihandler: Support QEMU CPUs
......................................................................
Patch Set 2:
(2 comments)
File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/c/coreboot/+/78088/comment/eca52c06_57d222d1 :
PS2, Line 257: if (detect_num_cpus_via_cpuid() == 1) {
Yes, but that's also the default if no argument was given.
Acknowledged
https://review.coreboot.org/c/coreboot/+/78088/comment/f0725b9c_cfdcfdd6 :
PS2, Line 274: if (CONFIG(BOARD_EMULATION_QEMU_X86_Q35)) {
Looks like CB:45476 would be the best solution.
Possibly you meant get/set_save_state() in general, the preceding CB:45475 with the dependencies. Something I could rebase.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78088?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9d1bacfc67272de867a1184c75c6dd16223cb83a
Gerrit-Change-Number: 78088
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 03 Oct 2023 10:51:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment