HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31925
Change subject: src/nsc/common/nsc.h: Drop unused includes ......................................................................
src/nsc/common/nsc.h: Drop unused includes
Change-Id: Id3501e65a9d0c0b5ad98679f5e78f985e87cbe55 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/nsc/common/nsc.h 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/31925/1
diff --git a/src/superio/nsc/common/nsc.h b/src/superio/nsc/common/nsc.h index c2d732c..bc123d4 100644 --- a/src/superio/nsc/common/nsc.h +++ b/src/superio/nsc/common/nsc.h @@ -18,7 +18,6 @@ #ifndef SUPERIO_NSC_COMMON_PRE_RAM_H #define SUPERIO_NSC_COMMON_PRE_RAM_H
-#include <device/pnp_def.h> #include <stdint.h> #include <device/pnp_type.h>
Hello Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31925
to look at the new patch set (#2).
Change subject: src/nsc/common/nsc.h: Drop unused include ......................................................................
src/nsc/common/nsc.h: Drop unused include
Change-Id: Id3501e65a9d0c0b5ad98679f5e78f985e87cbe55 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/nsc/common/nsc.h 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/31925/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31925 )
Change subject: src/nsc/common/nsc.h: Drop unused include ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31925 )
Change subject: src/nsc/common/nsc.h: Drop unused include ......................................................................
src/nsc/common/nsc.h: Drop unused include
Change-Id: Id3501e65a9d0c0b5ad98679f5e78f985e87cbe55 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31925 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/nsc/common/nsc.h 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/superio/nsc/common/nsc.h b/src/superio/nsc/common/nsc.h index c2d732c..bc123d4 100644 --- a/src/superio/nsc/common/nsc.h +++ b/src/superio/nsc/common/nsc.h @@ -18,7 +18,6 @@ #ifndef SUPERIO_NSC_COMMON_PRE_RAM_H #define SUPERIO_NSC_COMMON_PRE_RAM_H
-#include <device/pnp_def.h> #include <stdint.h> #include <device/pnp_type.h>
-
Felix Held (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)