Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85667?usp=email )
Change subject: soc/mediatek/mt8189: Add GPIO driver
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/mt8189/gpio.c:
https://review.coreboot.org/c/coreboot/+/85667/comment/96903a31_9fb298a2?usp... :
PS2, Line 264: if (raw_id >= ARRAY_SIZE(gpio_driving_info))
Vince, could you upload another patch similar to CB:74063 to reduce the bootblock size?
Updated in https://review.coreboot.org/c/coreboot/+/86538
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85667?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia87fe0975add95fcfad16d55586559c7f912a624
Gerrit-Change-Number: 85667
Gerrit-PatchSet: 2
Gerrit-Owner: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Thu, 20 Feb 2025 07:56:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com