Attention is currently required from: Michał Żygowski, Jakub Czapiga, Karol Zmyslowski, Stefan Reinauer, Michal Zygowski.
Maciej Pijanowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73934 )
Change subject: util/inteltool: Add support for Jasper Lake
......................................................................
Patch Set 9:
(3 comments)
File util/inteltool/gpio_names/jasperlake.h:
https://review.coreboot.org/c/coreboot/+/73934/comment/afce363e_8d0d2069
PS9, Line 496: const char *const jasperlake_pch_group_dsw_names[] = {
This should be: "jasperlake_pch_group_gpd_names"
https://review.coreboot.org/c/coreboot/+/73934/comment/d3ac64ce_1ac55a1f
PS9, Line 510: const struct gpio_group jasperlake_pch_group_dsw = {
This should be: jasperlake_pch_group_gpd
https://review.coreboot.org/c/coreboot/+/73934/comment/e578514c_432d3263
PS9, Line 511: .display = "------- GPIO Group GPP_S -------",
This should be: "------- GPIO Group GPD -------:
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4134bd03f5544b5845cde998ee526e5ddd5b51d
Gerrit-Change-Number: 73934
Gerrit-PatchSet: 9
Gerrit-Owner: Karol Zmyslowski
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michal Zygowski
miczyg94@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Karol Zmyslowski
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Michal Zygowski
miczyg94@gmail.com
Gerrit-Comment-Date: Tue, 04 Apr 2023 12:52:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment