Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu.
Jeff Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69500 )
Change subject: src/soc/intel/xeon_sp/ras/hest.c: fix HEST table length
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/xeon_sp/ras/hest.c:
https://review.coreboot.org/c/coreboot/+/69500/comment/3142aa44_a3996b25
PS3, Line 62: void *current;
: current = (void *)(hest);
: void *next = current;
: next = hest + 1;
Arithmetics on pointers to void is not defined in C. […]
Thank you for pointing out this problem of arithmetics on pointers to void. I agree with you to avoid this.
By the way, the next won't be in the middle of the header, because `hest + 1' does skip the acpi_hest_t struct. And stoneyridge code also use arithmetics on pointers to void in function acpi_fill_hest.
To avoid arithmetics on pointers to void completely, is it possible to add CFLAGS -Werror=pointer-arith?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69500
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4780785bac782aa966def3f042f365a1ead9d9d8
Gerrit-Change-Number: 69500
Gerrit-PatchSet: 6
Gerrit-Owner: Jeff Li
lijinfeng01@inspur.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 14 Nov 2022 16:22:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment