Change in ...coreboot[master]: autoport: Generate a libgfxinit template

[Iru Cai (vimacs) (Code Review)]

Hello Iru Cai,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/30912

to review the following change.

Change subject: autoport: Generate a libgfxinit template
......................................................................

autoport: Generate a libgfxinit template

Change-Id: I213628e525cc11c502de7d538bd60f49f3a930b9
Signed-off-by: Iru Cai 
---
M util/autoport/main.go
1 file changed, 42 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/30912/1

diff --git a/util/autoport/main.go b/util/autoport/main.go
index 05a829b..c1a7907 100644
--- a/util/autoport/main.go
+++ b/util/autoport/main.go
@@ -748,6 +748,10 @@

ScanRoot(ctx)

+	KconfigBool["MAINBOARD_HAS_LIBGFXINIT"] = true
+	KconfigComment["MAINBOARD_HAS_LIBGFXINIT"] = "FIXME: check this"
+	AddRAMStageFile("gma-mainboard.ads", "CONFIG_MAINBOARD_USE_LIBGFXINIT")
+
    if len(ROMStageFiles) > 0 || len(RAMStageFiles) > 0 || len(SMMFiles) > 0 {
    	mf := Create(ctx, "Makefile.inc")
    	defer mf.Close()
@@ -882,4 +886,42 @@
 }
 `)

+	gma := Create(ctx, "gma-mainboard.ads")
+	defer gma.Close()
+
+	gma.WriteString(`--
+-- This file is part of the coreboot project.
+--
+-- This program is free software; you can redistribute it and/or modify
+-- it under the terms of the GNU General Public License as published by
+-- the Free Software Foundation; either version 2 of the License, or
+-- (at your option) any later version.
+--
+-- This program is distributed in the hope that it will be useful,
+-- but WITHOUT ANY WARRANTY; without even the implied warranty of
+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+-- GNU General Public License for more details.
+--
+
+with HW.GFX.GMA;
+with HW.GFX.GMA.Display_Probing;
+
+use HW.GFX.GMA;
+use HW.GFX.GMA.Display_Probing;
+
+private package GMA.Mainboard is
+
+   ports : constant Port_List :=
+     (DP1,
+      DP2,
+      DP3,
+      HDMI1,
+      HDMI2,
+      HDMI3,
+      Analog,
+      Internal,
+      others => Disabled);
+
+end GMA.Mainboard;
+`)
 }

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30912 )

Change subject: autoport: Generate a libgfxinit template
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/30912/1/util/autoport/main.go 
File util/autoport/main.go:

https://review.coreboot.org/#/c/30912/1/util/autoport/main.go@751 
PS1, Line 751: 	KconfigBool["MAINBOARD_HAS_LIBGFXINIT"] = true
             : 	KconfigComment["MAINBOARD_HAS_LIBGFXINIT"] = "FIXME: check this"
             : 	AddRAMStageFile("gma-mainboard.ads", "CONFIG_MAINBOARD_USE_LIBGFXINIT")
Maybe out of the scope of this patch, but would autodetecting whether the IGD is enabled help?

https://review.coreboot.org/#/c/30912/1/util/autoport/main.go@914 
PS1, Line 914: ports
Somewhere nearby: -- FIXME: check this

Change in ...coreboot[master]: autoport: Generate a libgfxinit template when IGD is detected

[Iru Cai (vimacs) (Code Review)]

Hello Iru Cai, Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/30912

to look at the new patch set (#2).

Change subject: autoport: Generate a libgfxinit template when IGD is detected
......................................................................

autoport: Generate a libgfxinit template when IGD is detected

Change-Id: I213628e525cc11c502de7d538bd60f49f3a930b9
Signed-off-by: Iru Cai 
---
M util/autoport/main.go
1 file changed, 50 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/30912/2

Change in ...coreboot[master]: autoport: Generate a libgfxinit template when IGD is detected

[Iru Cai (vimacs) (Code Review)]

Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30912 )

Change subject: autoport: Generate a libgfxinit template when IGD is detected
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/30912/1/util/autoport/main.go 
File util/autoport/main.go:

https://review.coreboot.org/#/c/30912/1/util/autoport/main.go@751 
PS1, Line 751: 	KconfigBool["MAINBOARD_HAS_LIBGFXINIT"] = true
             : 	KconfigComment["MAINBOARD_HAS_LIBGFXINIT"] = "FIXME: check this"
             : 	AddRAMStageFile("gma-mainboard.ads", "CONFIG_MAINBOARD_USE_LIBGFXINIT")
> Maybe out of the scope of this patch, but would autodetecting whether the IGD is enabled help?

Done

https://review.coreboot.org/#/c/30912/1/util/autoport/main.go@914 
PS1, Line 914: ports
> Somewhere nearby: -- FIXME: check this

Done

Change in ...coreboot[master]: autoport: Generate a libgfxinit template when IGD is detected

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30912 )

Change subject: autoport: Generate a libgfxinit template when IGD is detected
......................................................................

Patch Set 2: Code-Review+2

Change in ...coreboot[master]: autoport: Generate a libgfxinit template when IGD is detected

[Felix Held (Code Review)]

Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30912 )

Change subject: autoport: Generate a libgfxinit template when IGD is detected
......................................................................

autoport: Generate a libgfxinit template when IGD is detected

Change-Id: I213628e525cc11c502de7d538bd60f49f3a930b9
Signed-off-by: Iru Cai 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/30912
Tested-by: build bot (Jenkins) 
Reviewed-by: Felix Held 
---
M util/autoport/main.go
1 file changed, 50 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved

diff --git a/util/autoport/main.go b/util/autoport/main.go
index dc02a8d..ab49a14 100644
--- a/util/autoport/main.go
+++ b/util/autoport/main.go
@@ -517,6 +517,8 @@
    PutPCIDevParent(addr, g.Comment, g.MissingParent)
 }

+var IGDEnabled bool = false
+
 func (g GenericVGA) Scan(ctx Context, addr PCIDevData) {
    KconfigString["VGA_BIOS_ID"] = fmt.Sprintf("%04x,%04x",
    	addr.PCIVenID,
@@ -525,6 +527,7 @@
    	addr.PCIVenID,
    	addr.PCIDevID)
    PutPCIDevParent(addr, g.Comment, g.MissingParent)
+	IGDEnabled = true
 }

func makeKconfigName(ctx Context) {
@@ -748,6 +751,12 @@

ScanRoot(ctx)

+	if IGDEnabled {
+		KconfigBool["MAINBOARD_HAS_LIBGFXINIT"] = true
+		KconfigComment["MAINBOARD_HAS_LIBGFXINIT"] = "FIXME: check this"
+		AddRAMStageFile("gma-mainboard.ads", "CONFIG_MAINBOARD_USE_LIBGFXINIT")
+	}
+
    if len(ROMStageFiles) > 0 || len(RAMStageFiles) > 0 || len(SMMFiles) > 0 {
    	mf := Create(ctx, "Makefile.inc")
    	defer mf.Close()
@@ -881,4 +890,45 @@
 }
 `)

+	if IGDEnabled {
+		gma := Create(ctx, "gma-mainboard.ads")
+		defer gma.Close()
+
+		gma.WriteString(`--
+-- This file is part of the coreboot project.
+--
+-- This program is free software; you can redistribute it and/or modify
+-- it under the terms of the GNU General Public License as published by
+-- the Free Software Foundation; either version 2 of the License, or
+-- (at your option) any later version.
+--
+-- This program is distributed in the hope that it will be useful,
+-- but WITHOUT ANY WARRANTY; without even the implied warranty of
+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+-- GNU General Public License for more details.
+--
+
+with HW.GFX.GMA;
+with HW.GFX.GMA.Display_Probing;
+
+use HW.GFX.GMA;
+use HW.GFX.GMA.Display_Probing;
+
+private package GMA.Mainboard is
+
+   -- FIXME: check this
+   ports : constant Port_List :=
+     (DP1,
+      DP2,
+      DP3,
+      HDMI1,
+      HDMI2,
+      HDMI3,
+      Analog,
+      Internal,
+      others => Disabled);
+
+end GMA.Mainboard;
+`)
+	}
 }