Attention is currently required from: Subrata Banik, Maulik V Vaghela, Paul Menzel, Tim Wawrzynczak, Prashant Malani, Meera Ravindranath, Nick Vaccaro, Rajat Jain.
Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61622 )
Change subject: mb/google/brya/{}: Add SBU orientation property for Type C Mux
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
File src/mainboard/google/brya/variants/felwinter/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/61622/comment/5a0a7961_b3d385d2
PS6, Line 328: # SBU is fixed, HSL follows CC
: register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
@Deepti, can you pls comment here?
If these properties are not exposed in ACPI, then kernel driver fallback in CC orientation to get this values.
Hence change is needed only for the ports with retimer.
File src/mainboard/google/brya/variants/taeko/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/61622/comment/af4eb67f_6fad558f
PS6, Line 450: # SBU is fixed, HSL follows CC
: register "sbu_orientation" = "TYPEC_ORIENTATION_NORM
@Deepti, pls comment here.
yes the port0 is a direct port.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61622
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f7f9554b75f4d62298aac9938e66c71c3e7cee9
Gerrit-Change-Number: 61622
Gerrit-PatchSet: 6
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Prashant Malani
pmalani@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rajat Jain
rajatja@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Prashant Malani
pmalani@google.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Prashant Malani
pmalani@chromium.org
Gerrit-Attention: Rajat Jain
rajatja@google.com
Gerrit-Comment-Date: Wed, 13 Apr 2022 13:31:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Prashant Malani
pmalani@google.com
Comment-In-Reply-To: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-MessageType: comment