Martin Roth has posted comments on this change. ( https://review.coreboot.org/27561 )
Change subject: drivers/i2c/da7219: Add vddio property ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/27561/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/27561/1//COMMIT_MSG@17 PS1, Line 17: Needs a signed-off-by line
https://review.coreboot.org/#/c/27561/1/src/drivers/i2c/da7219/chip.h File src/drivers/i2c/da7219/chip.h:
https://review.coreboot.org/#/c/27561/1/src/drivers/i2c/da7219/chip.h@33 PS1, Line 33: unsigned vddio;
Thank you for the advice Jenkins, but I was keeping consistent with the rest of this file here.
As I was reminded yesterday, consistency is the hallmark of excellence. I guess I can push a follow-on patch to fix it across the board.
-
Martin Roth (Code Review)