David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34431 )
Change subject: mb/google/hatch: expose get_board_sku() as global ......................................................................
mb/google/hatch: expose get_board_sku() as global
BUG=None TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I217e13acd337034554ff055e8bf5011558d1f8bf Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/mainboard.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h 2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/34431/1
diff --git a/src/mainboard/google/hatch/mainboard.c b/src/mainboard/google/hatch/mainboard.c index eb77a00..94f7436 100644 --- a/src/mainboard/google/hatch/mainboard.c +++ b/src/mainboard/google/hatch/mainboard.c @@ -23,7 +23,7 @@ #define SKU_UNKNOWN 0xFFFFFFFF #define SKU_MAX 255
-static uint32_t get_board_sku(void) +uint32_t get_board_sku(void) { static uint32_t sku_id = SKU_UNKNOWN;
diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h index fa43903..4d24efc 100644 --- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h @@ -40,6 +40,9 @@ /* Return ChromeOS gpio table and fill in number of entries. */ const struct cros_gpio *variant_cros_gpios(size_t *num);
+/* Return board SKU */ +uint32_t get_board_sku(void); + /* Modify devictree settings during ramstage. */ void variant_devtree_update(void);
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34431 )
Change subject: mb/google/hatch: expose get_board_sku() as global ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34431/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34431/1/src/mainboard/google/hatch/... PS1, Line 16: #include <boardid.h> You need to include <baseboard/variants.h> here
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34431
to look at the new patch set (#2).
Change subject: mb/google/hatch: expose get_board_sku() as global ......................................................................
mb/google/hatch: expose get_board_sku() as global
BUG=None TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I217e13acd337034554ff055e8bf5011558d1f8bf Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/mainboard.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/34431/2
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34431 )
Change subject: mb/google/hatch: expose get_board_sku() as global ......................................................................
Patch Set 2:
(1 comment)
Thank you so much.
https://review.coreboot.org/c/coreboot/+/34431/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34431/1/src/mainboard/google/hatch/... PS1, Line 16: #include <boardid.h>
You need to include <baseboard/variants. […]
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34431 )
Change subject: mb/google/hatch: expose get_board_sku() as global ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34431/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34431/2/src/mainboard/google/hatch/... PS2, Line 17: #include <baseboard/variants.h> nit: this should go before boardid.h to keep the files in alphabetical order.
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34431
to look at the new patch set (#3).
Change subject: mb/google/hatch: expose get_board_sku() as global ......................................................................
mb/google/hatch: expose get_board_sku() as global
BUG=None TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I217e13acd337034554ff055e8bf5011558d1f8bf Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/mainboard.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/34431/3
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34431 )
Change subject: mb/google/hatch: expose get_board_sku() as global ......................................................................
Patch Set 3:
(1 comment)
Thanks.
https://review.coreboot.org/c/coreboot/+/34431/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34431/2/src/mainboard/google/hatch/... PS2, Line 17: #include <baseboard/variants.h>
nit: this should go before boardid.h to keep the files in alphabetical order.
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34431 )
Change subject: mb/google/hatch: expose get_board_sku() as global ......................................................................
Patch Set 3: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34431 )
Change subject: mb/google/hatch: expose get_board_sku() as global ......................................................................
mb/google/hatch: expose get_board_sku() as global
BUG=None TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I217e13acd337034554ff055e8bf5011558d1f8bf Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34431 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/mainboard.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h 2 files changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/mainboard.c b/src/mainboard/google/hatch/mainboard.c index eb77a00..4d5e8ed 100644 --- a/src/mainboard/google/hatch/mainboard.c +++ b/src/mainboard/google/hatch/mainboard.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */
+#include <baseboard/variants.h> #include <boardid.h> #include <console/console.h> #include <ec/google/chromeec/ec.h> @@ -23,7 +24,7 @@ #define SKU_UNKNOWN 0xFFFFFFFF #define SKU_MAX 255
-static uint32_t get_board_sku(void) +uint32_t get_board_sku(void) { static uint32_t sku_id = SKU_UNKNOWN;
diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h index 4cb1194..71a2362 100644 --- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h @@ -43,6 +43,9 @@ /* Return ChromeOS gpio table and fill in number of entries. */ const struct cros_gpio *variant_cros_gpios(size_t *num);
+/* Return board SKU */ +uint32_t get_board_sku(void); + /* Modify devictree settings during ramstage. */ void variant_devtree_update(void);
-
David Wu (Code Review) -
Furquan Shaikh (Code Review)
-
Martin Roth (Code Review)