Attention is currently required from: Andrey Petrov, Angel Pons, Arthur Heymans, Michał Żygowski, Subrata Banik.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65270?usp=email )
Change subject: soc/intel/apollolake: Add a loader for the IBB
......................................................................
Patch Set 75:
(2 comments)
File src/soc/intel/apollolake/bootflow.md:
https://review.coreboot.org/c/coreboot/+/65270/comment/4259b3ee_bed753da :
PS74, Line 11: When we enter the bootblock, the first 128k will be copied
: into the SRAM. This will contain the IBBL partition (bootblock)
: and whatever will fix of the IBB partition.
Take a look at Figure 8-1 in doc 571119, it shows the SRAM layout at CPU reset. […]
Done
File src/soc/intel/apollolake/loader.c:
https://review.coreboot.org/c/coreboot/+/65270/comment/23f97a22_c3d856ed :
PS67, Line 31:
: uint32_t chunk_num;
: uint32_t state;
: uint32_t size;
: uint8_t ring_index;
: uint32_t sram_size = SHARED_SRAM_SIZE;
: uint32_t sram_base = SHARED_SRAM_BASE;
: uint32_t host_to_cse;
: uint32_t cse_to_host;
: uint32_t chunk_index = 0;
: uint32_t chunk_size;
: uint32_t number_of_chunks;
: uint32_t ibb_size_left;
: uint8_t *src;
: uint8_t *dst;
You could reduce the scope of some variables
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/65270?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia41e3909f8099d2ea864166e9ea03e10e40a1b68
Gerrit-Change-Number: 65270
Gerrit-PatchSet: 75
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Thu, 21 Mar 2024 15:44:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment