Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48775 )
Change subject: {soc,vc,mb}/intel: Remove support for Cannon Lake SoC ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48775/3/src/soc/intel/cannonlake/Kc... File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/48775/3/src/soc/intel/cannonlake/Kc... PS3, Line 4: config SOC_INTEL_CANNONLAKE_ALTERNATE_HEADERS There is only one default left. Please remove it too and all references to it.
https://review.coreboot.org/c/coreboot/+/48775/3/src/soc/intel/cannonlake/Kc... PS3, Line 85: select HECI_DISABLE_USING_SMM if !SOC_INTEL_COFFEELAKE && !SOC_INTEL_WHISKEYLAKE && !SOC_INTEL_COMETLAKE Looks dead too.
-
Nico Huber (Code Review)