Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48925 )
Change subject: device/pnp,util/sconfig: introduce and use `REG8` resource type
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48925/6/src/device/pnp_device.c
File src/device/pnp_device.c:
https://review.coreboot.org/c/coreboot/+/48925/6/src/device/pnp_device.c@105
PS6, Line 105: 0x30
Yup, it's there and even in some devicetrees touched by this commit. […]
agreed, thanks
https://review.coreboot.org/c/coreboot/+/48925/6/src/device/pnp_device.c@137
PS6, Line 137: } else if (resource->flags & IORESOURCE_DRQ) {
: pnp_set_drq(dev, resource->index, resource->base);
: } else if (resource->flags & IORESOURCE_IRQ) {
: pnp_set_irq(dev, resource->index, resource->base);
: } else if (resource->flags & IORESOURCE_REG8) {
: pnp_set_reg8(dev, resource->index, resource->base);
The generic code in `src/device/` does nothing about them. For I/O we […]
src/drivers/pc80/tpm/tis.c: lpc_tpm_set_resources() checks for IORESOURCE_IRQ, we could instead maybe check for the resource index there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36679148cbfdbd1e38b3c4ce092562769f9806ab
Gerrit-Change-Number: 48925
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 28 Dec 2020 20:10:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment