Change in coreboot[master]: Doc/mb/hp: rename the document about HP laptops with KBC1126
Hello Iru Cai,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/40315
to review the following change.
Change subject: Doc/mb/hp: rename the document about HP laptops with KBC1126 ......................................................................
Doc/mb/hp: rename the document about HP laptops with KBC1126
Later EliteBooks use different EC chips and have different EC firmware interfaces, so rename the document elitebook_series.md to a more precise name and also do some rewriting.
A link to the code review page for 8760w is also added because the port for this laptop is not merged yet.
Change-Id: I2f9b8c4e52ed760c16977d16838cca9e490cda05 Signed-off-by: Iru Cai mytbk920423@gmail.com --- M Documentation/mainboard/hp/8760w.md R Documentation/mainboard/hp/hp_kbc1126_laptops.md M Documentation/mainboard/index.md 3 files changed, 20 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/40315/1
diff --git a/Documentation/mainboard/hp/8760w.md b/Documentation/mainboard/hp/8760w.md index 714745a..071d35e 100644 --- a/Documentation/mainboard/hp/8760w.md +++ b/Documentation/mainboard/hp/8760w.md @@ -2,6 +2,9 @@
This page describes how to run coreboot on the [HP EliteBook 8760w].
+The coreboot code for this laptop is still not merged, you need to +checkout the [code on gerrit] to build coreboot for the laptop. + ## Flashing coreboot
```eval_rst @@ -29,7 +32,7 @@ ## Required proprietary blobs
- Intel Firmware Descriptor, ME and GbE firmware -- EC: please read [EliteBook Series](elitebook_series) +- EC: please read [HP Laptops with KBC1126 Embedded Controller](hp_kbc1126_laptops)
## Flashing instructions
@@ -80,3 +83,4 @@ ```
[HP EliteBook 8760w]: https://support.hp.com/us-en/product/hp-elitebook-8760w-mobile-workstation/5... +[code on gerrit]: https://review.coreboot.org/c/coreboot/+/30936 diff --git a/Documentation/mainboard/hp/elitebook_series.md b/Documentation/mainboard/hp/hp_kbc1126_laptops.md similarity index 81% rename from Documentation/mainboard/hp/elitebook_series.md rename to Documentation/mainboard/hp/hp_kbc1126_laptops.md index 6668928..357af4f 100644 --- a/Documentation/mainboard/hp/elitebook_series.md +++ b/Documentation/mainboard/hp/hp_kbc1126_laptops.md @@ -1,13 +1,14 @@ -# HP EliteBook series +# HP Laptops with KBC1126 Embedded Controller
This document is about HP EliteBook series laptops up to Ivy Bridge era which use SMSC KBC1126 as embedded controller.
-## EC +SMSC KBC1126 (and older similar chips like KBC1098) has been used in +HP EliteBooks for many generations. BIOS and EC firmware share an SPI +flash chip in these laptops, so we need to put firmware blobs for the +EC to the coreboot image.
-SMSC KBC1098/KBC1126 has been used in HP EliteBooks for many generations. -They use similar EC firmware that will load other code and data from the -SPI flash chip, so we need to put some firmware blobs to the coreboot image. +## EC firmware extraction and coreboot building
The following document takes EliteBook 2760p as an example.
@@ -32,18 +33,15 @@ (2760p-fw2.bin) KBC1126 filename #2 path and filename ```
-## Super I/O +## Porting guide for HP laptops with KBC1126
-EliteBook 8000 series laptops have SMSC LPC47n217 Super I/O to provide -a serial port and a parallel port, you can debug the laptop via this -serial port. - -## porting - -To port coreboot to an HP EliteBook laptop, you need to do the following: +To port coreboot to an HP laptop with KBC1126, you need to do the +following:
- select Kconfig option `EC_HP_KBC1126` -- select Kconfig option `SUPERIO_SMSC_LPC47N217` if there is LPC47n217 Super I/O +- select Kconfig option `SUPERIO_SMSC_LPC47N217` if there is LPC47n217 + Super I/O, usually in EliteBook 8000 series, which can be used for + debugging via serial port - initialize EC and Super I/O in romstage - add EC and Super I/O support to devicetree.cb
@@ -51,8 +49,8 @@ module EcThermalInit from the vendor UEFI firmware with [UEFITool]. Usually, `ec_data_port`, `ec_cmd_port` and `ec_ctrl_reg` has the following values:
-- For xx60 series: 0x60, 0x64, 0xca -- For xx70 series: 0x62, 0x66, 0x81 +- For EliteBook xx60 series: 0x60, 0x64, 0xca +- For EliteBook xx70 series: 0x62, 0x66, 0x81
You can use [radare2] and the following [r2pipe] Python script to find these values from the EcThermalInit EFI module: diff --git a/Documentation/mainboard/index.md b/Documentation/mainboard/index.md index 7637f7b..57df302 100644 --- a/Documentation/mainboard/index.md +++ b/Documentation/mainboard/index.md @@ -58,7 +58,7 @@
### EliteBook series
-- [EliteBook common](hp/elitebook_series.md) +- [HP Laptops with KBC1126 EC](hp/hp_kbc1126_laptops.md) - [EliteBook 8760w](hp/8760w.md)
## Intel
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40315 )
Change subject: Doc/mb/hp: rename the document about HP laptops with KBC1126 ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40315 )
Change subject: Doc/mb/hp: rename the document about HP laptops with KBC1126 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40315/1/Documentation/mainboard/hp/... File Documentation/mainboard/hp/hp_kbc1126_laptops.md:
https://review.coreboot.org/c/coreboot/+/40315/1/Documentation/mainboard/hp/... PS1, Line 4: which use SMSC KBC1126 as embedded controller. Adapt this also, and keep EliteBook as an example?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40315 )
Change subject: Doc/mb/hp: rename the document about HP laptops with KBC1126 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40315/1/Documentation/mainboard/hp/... File Documentation/mainboard/hp/hp_kbc1126_laptops.md:
https://review.coreboot.org/c/coreboot/+/40315/1/Documentation/mainboard/hp/... PS1, Line 4: which use SMSC KBC1126 as embedded controller.
Adapt this also, and keep EliteBook as an example?
I don't think the intent was to add non-EliteBook KBC1126 devices to the scope of the doc, but to exclude non-KBC1126 Elitebooks, so this seems entirely correct.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40315 )
Change subject: Doc/mb/hp: rename the document about HP laptops with KBC1126 ......................................................................
Doc/mb/hp: rename the document about HP laptops with KBC1126
Later EliteBooks use different EC chips and have different EC firmware interfaces, so rename the document elitebook_series.md to a more precise name and also do some rewriting.
A link to the code review page for 8760w is also added because the port for this laptop is not merged yet.
Change-Id: I2f9b8c4e52ed760c16977d16838cca9e490cda05 Signed-off-by: Iru Cai mytbk920423@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40315 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Documentation/mainboard/hp/8760w.md R Documentation/mainboard/hp/hp_kbc1126_laptops.md M Documentation/mainboard/index.md 3 files changed, 20 insertions(+), 18 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/Documentation/mainboard/hp/8760w.md b/Documentation/mainboard/hp/8760w.md index 714745a..071d35e 100644 --- a/Documentation/mainboard/hp/8760w.md +++ b/Documentation/mainboard/hp/8760w.md @@ -2,6 +2,9 @@
This page describes how to run coreboot on the [HP EliteBook 8760w].
+The coreboot code for this laptop is still not merged, you need to +checkout the [code on gerrit] to build coreboot for the laptop. + ## Flashing coreboot
```eval_rst @@ -29,7 +32,7 @@ ## Required proprietary blobs
- Intel Firmware Descriptor, ME and GbE firmware -- EC: please read [EliteBook Series](elitebook_series) +- EC: please read [HP Laptops with KBC1126 Embedded Controller](hp_kbc1126_laptops)
## Flashing instructions
@@ -80,3 +83,4 @@ ```
[HP EliteBook 8760w]: https://support.hp.com/us-en/product/hp-elitebook-8760w-mobile-workstation/5... +[code on gerrit]: https://review.coreboot.org/c/coreboot/+/30936 diff --git a/Documentation/mainboard/hp/elitebook_series.md b/Documentation/mainboard/hp/hp_kbc1126_laptops.md similarity index 81% rename from Documentation/mainboard/hp/elitebook_series.md rename to Documentation/mainboard/hp/hp_kbc1126_laptops.md index 6668928..357af4f 100644 --- a/Documentation/mainboard/hp/elitebook_series.md +++ b/Documentation/mainboard/hp/hp_kbc1126_laptops.md @@ -1,13 +1,14 @@ -# HP EliteBook series +# HP Laptops with KBC1126 Embedded Controller
This document is about HP EliteBook series laptops up to Ivy Bridge era which use SMSC KBC1126 as embedded controller.
-## EC +SMSC KBC1126 (and older similar chips like KBC1098) has been used in +HP EliteBooks for many generations. BIOS and EC firmware share an SPI +flash chip in these laptops, so we need to put firmware blobs for the +EC to the coreboot image.
-SMSC KBC1098/KBC1126 has been used in HP EliteBooks for many generations. -They use similar EC firmware that will load other code and data from the -SPI flash chip, so we need to put some firmware blobs to the coreboot image. +## EC firmware extraction and coreboot building
The following document takes EliteBook 2760p as an example.
@@ -32,18 +33,15 @@ (2760p-fw2.bin) KBC1126 filename #2 path and filename ```
-## Super I/O +## Porting guide for HP laptops with KBC1126
-EliteBook 8000 series laptops have SMSC LPC47n217 Super I/O to provide -a serial port and a parallel port, you can debug the laptop via this -serial port. - -## porting - -To port coreboot to an HP EliteBook laptop, you need to do the following: +To port coreboot to an HP laptop with KBC1126, you need to do the +following:
- select Kconfig option `EC_HP_KBC1126` -- select Kconfig option `SUPERIO_SMSC_LPC47N217` if there is LPC47n217 Super I/O +- select Kconfig option `SUPERIO_SMSC_LPC47N217` if there is LPC47n217 + Super I/O, usually in EliteBook 8000 series, which can be used for + debugging via serial port - initialize EC and Super I/O in romstage - add EC and Super I/O support to devicetree.cb
@@ -51,8 +49,8 @@ module EcThermalInit from the vendor UEFI firmware with [UEFITool]. Usually, `ec_data_port`, `ec_cmd_port` and `ec_ctrl_reg` has the following values:
-- For xx60 series: 0x60, 0x64, 0xca -- For xx70 series: 0x62, 0x66, 0x81 +- For EliteBook xx60 series: 0x60, 0x64, 0xca +- For EliteBook xx70 series: 0x62, 0x66, 0x81
You can use [radare2] and the following [r2pipe] Python script to find these values from the EcThermalInit EFI module: diff --git a/Documentation/mainboard/index.md b/Documentation/mainboard/index.md index 7637f7b..57df302 100644 --- a/Documentation/mainboard/index.md +++ b/Documentation/mainboard/index.md @@ -58,7 +58,7 @@
### EliteBook series
-- [EliteBook common](hp/elitebook_series.md) +- [HP Laptops with KBC1126 EC](hp/hp_kbc1126_laptops.md) - [EliteBook 8760w](hp/8760w.md)
## Intel
-
Angel Pons (Code Review) -
Iru Cai (vimacs) (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)