Attention is currently required from: Furquan Shaikh, Kevin Chang, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 )
Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/volteer/romstage.c:
https://review.coreboot.org/c/coreboot/+/51200/comment/07f86d34_18fd021c
PS5, Line 28: void __weak memcfg_variant_init(FSPM_UPD *mupd)
: {
: uint32_t board_version;
: FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig;
:
: if ((google_chromeec_get_board_version(&board_version) == 0) && (board_version == 1))
: mem_cfg->SaGv = 0x00;
: }
This should be put to the lindar/memory.c. You can just put the empty function for the other projects:
void __weak memcfg_variant_init(FSPM_UPD *mupd)
{
}
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/51200/comment/6d3682b2_7d38f725
PS5, Line 23: __weak
remove the __weak
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51200
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f
Gerrit-Change-Number: 51200
Gerrit-PatchSet: 5
Gerrit-Owner: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Lauren Ting
lauren.ting@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 04 Mar 2021 02:45:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment