Attention is currently required from: Furquan Shaikh, Kevin Chang, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro.

View Change

2 comments:

• File src/mainboard/google/volteer/romstage.c:

  • Patch Set #5, Line 28:

    void __weak memcfg_variant_init(FSPM_UPD *mupd)
    {
    	uint32_t board_version;
    	FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig;
    
    	if ((google_chromeec_get_board_version(&board_version) == 0) && (board_version == 1))
    		mem_cfg->SaGv = 0x00;
    }
    

    This should be put to the lindar/memory.c. You can just put the empty function for the other projects:

    void __weak memcfg_variant_init(FSPM_UPD *mupd)
    {
    }

• File src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h:

  • Patch Set #5, Line 23: __weak

    remove the __weak

To view, visit change 51200. To unsubscribe, or for help writing mail filters, visit settings.