Change in coreboot[master]: lib: Rename edid_fill_fb.c

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: [HACK]...

Patrick Rudolph (Code Review)

10 Mar 2020 10 Mar '20

3:44 p.m.

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39431 )

Change subject: lib: Rename edid_fill_fb.c ......................................................................

lib: Rename edid_fill_fb.c

Rename edid_fill_fb.c to framebuffer_info.c as it doesn't deal with EDID that much any more.

Change-Id: Ic7eb6432eee9808aaa9a48e6bcd61bf136a8b938 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/lib/Makefile.inc R src/lib/framebuffer_info.c 2 files changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/39431/1

diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index a1fb8c2..76ace63 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -134,7 +134,7 @@ ramstage-$(CONFIG_COLLECT_TIMESTAMPS) += timestamp.c ramstage-$(CONFIG_COVERAGE) += libgcov.c ramstage-y += edid.c -ramstage-y += edid_fill_fb.c +ramstage-y += framebuffer_info.c ramstage-y += memrange.c ramstage-$(CONFIG_COOP_MULTITASKING) += thread.c ramstage-$(CONFIG_TIMER_QUEUE) += timer_queue.c diff --git a/src/lib/edid_fill_fb.c b/src/lib/framebuffer_info.c similarity index 100% rename from src/lib/edid_fill_fb.c rename to src/lib/framebuffer_info.c

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Julius Werner (Code Review)

10 Mar 10 Mar

10:40 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39431 )

Change subject: lib: Rename edid_fill_fb.c ......................................................................

Patch Set 1: Code-Review+2

I feel like this would be better squashed into CB:39002, but okay.

Frans Hendriks (Code Review)

11 Mar 11 Mar

8:04 a.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39431 )

Change subject: lib: Rename edid_fill_fb.c ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7eb6432eee9808aaa9a48e6bcd61bf136a8b938 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 11 Mar 2020 08:04:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

19 Mar 19 Mar

9:50 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Frans Hendriks, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39431

to look at the new patch set (#2).

Change subject: lib: Rename edid_fill_fb.c ......................................................................

lib: Rename edid_fill_fb.c

Rename edid_fill_fb.c to framebuffer_info.c as it doesn't deal with EDID that much any more.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/39431/2

Julius Werner (Code Review)

11:18 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39431 )

Change subject: lib: Rename edid_fill_fb.c ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7eb6432eee9808aaa9a48e6bcd61bf136a8b938 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 19 Mar 2020 23:18:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

20 Mar 20 Mar

2:58 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39431 )

Change subject: lib: Rename edid_fill_fb.c ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/39431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7eb6432eee9808aaa9a48e6bcd61bf136a8b938 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 20 Mar 2020 14:58:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

23 Mar 23 Mar

8:28 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Frans Hendriks, Paul Menzel, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39431

to look at the new patch set (#4).

Change subject: lib: Rename edid_fill_fb.c ......................................................................

lib: Rename edid_fill_fb.c

Rename edid_fill_fb.c to framebuffer_info.c as it doesn't deal with EDID that much any more.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/39431/4

Patrick Rudolph (Code Review)

10:40 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Frans Hendriks, Paul Menzel, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39431

to look at the new patch set (#6).

Change subject: lib: Rename edid_fill_fb.c ......................................................................

lib: Rename edid_fill_fb.c

Rename edid_fill_fb.c to framebuffer_info.c as it doesn't deal with EDID that much any more.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/39431/6

Patrick Rudolph (Code Review)

26 Mar 26 Mar

7:34 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Frans Hendriks, Paul Menzel, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39431

to look at the new patch set (#8).

Change subject: lib: Rename edid_fill_fb.c ......................................................................

lib: Rename edid_fill_fb.c

Rename edid_fill_fb.c to framebuffer_info.c as it doesn't deal with EDID that much any more.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/39431/8

Marcello Sylvester Bauer (Code Review)

16 Apr 16 Apr

1:43 p.m.

Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39431 )

Change subject: lib: Rename edid_fill_fb.c ......................................................................

Patch Set 8: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/39431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7eb6432eee9808aaa9a48e6bcd61bf136a8b938 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 16 Apr 2020 13:43:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Arthur Heymans (Code Review)

3:40 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39431 )

Change subject: lib: Rename edid_fill_fb.c ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7eb6432eee9808aaa9a48e6bcd61bf136a8b938 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 16 Apr 2020 15:40:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

28 Apr 28 Apr

10:24 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Frans Hendriks, Paul Menzel, Julius Werner, Arthur Heymans, Marcello Sylvester Bauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39431

to look at the new patch set (#9).

Change subject: lib: Rename edid_fill_fb.c ......................................................................

lib: Rename edid_fill_fb.c

Rename edid_fill_fb.c to framebuffer_info.c as it doesn't deal with EDID that much any more.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/39431/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/39431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7eb6432eee9808aaa9a48e6bcd61bf136a8b938 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 9 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Patrick Rudolph (Code Review)

1:10 p.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Frans Hendriks, Paul Menzel, Julius Werner, Arthur Heymans, Marcello Sylvester Bauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39431

to look at the new patch set (#10).

Change subject: lib: Rename edid_fill_fb.c ......................................................................

lib: Rename edid_fill_fb.c

Rename edid_fill_fb.c to framebuffer_info.c as it doesn't deal with EDID that much any more.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/39431/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/39431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7eb6432eee9808aaa9a48e6bcd61bf136a8b938 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Christian Walter (Code Review)

22 Jun 22 Jun

3:01 p.m.

Christian Walter has uploaded a new patch set (#11) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/39431 )

Change subject: lib: Rename edid_fill_fb.c ......................................................................

lib: Rename edid_fill_fb.c

Rename edid_fill_fb.c to framebuffer_info.c as it doesn't deal with EDID that much any more.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/39431/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/39431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7eb6432eee9808aaa9a48e6bcd61bf136a8b938 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

18 Aug 18 Aug

3:32 p.m.

Angel Pons has uploaded a new patch set (#12) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/39431 )

Change subject: lib: Rename edid_fill_fb.c ......................................................................

lib: Rename edid_fill_fb.c

Rename edid_fill_fb.c to framebuffer_info.c as it doesn't deal with EDID that much any more.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/39431/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/39431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7eb6432eee9808aaa9a48e6bcd61bf136a8b938 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 12 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Frans Hendriks (Code Review)

19 Nov 19 Nov

1:15 p.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39431 )

Change subject: lib: Rename edid_fill_fb.c ......................................................................

Patch Set 13: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/39431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7eb6432eee9808aaa9a48e6bcd61bf136a8b938 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 13 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 19 Nov 2020 13:15:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin L Roth (Code Review)

7 Aug 7 Aug

8:47 p.m.

New subject: [XS] Change in coreboot[master]: lib: Rename edid_fill_fb.c

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39431?usp=email )

Change subject: lib: Rename edid_fill_fb.c ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39431?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7eb6432eee9808aaa9a48e6bcd61bf136a8b938 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 13 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin L Roth gaumless@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

507

days inactive

1752

days old

coreboot-gerrit@coreboot.org

16 comments

9 participants

tags (0)

participants (9)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
Christian Walter (Code Review)
Frans Hendriks (Code Review)
Julius Werner (Code Review)
Marcello Sylvester Bauer (Code Review)
Martin L Roth (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)