[XS] Change in coreboot[main]: soc/mediatek/mt8196: Initialize PMIF for SD Card - coreboot-gerrit

14 Jan 2025


      Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85969?usp=email )
Change subject: soc/mediatek/mt8196: Initialize PMIF for SD Card
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85969/comment/5dea04f4_937d3c2f?usp... :
PS2, Line 105: 		mt6373_init_pmif_arb();
...
Do you think it'd be cleaner to move the call inside `mtk_msdc_configure_sdcard`? I'm fine either wa […]
Calling it inside `mtk_msdc_configure_sdcard` makes sense to me.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85969?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e3265bb62a6c78d44e2c756be9a020a49a03056
Gerrit-Change-Number: 85969
Gerrit-PatchSet: 3
Gerrit-Owner: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Tue, 14 Jan 2025 11:03:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com