Attention is currently required from: Karthik Ramasubramanian, Tanu Malhotra, Yuval Peress.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81418?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox: Configure ISH device based on FW_CONFIG ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81418/comment/bcfba36c_12ff37a2 : PS2, Line 10: Similarly dma : property needs to be added only when UFS is enabled through STORAGE_UFS : FW_CONFIG. the UFS related change is not captured in the title of the patch, may be split into two patches ?
File src/mainboard/google/brox/variants/brox/fw_config.c:
https://review.coreboot.org/c/coreboot/+/81418/comment/60e39cac_c7d4cb04 : PS2, Line 42: if (fw_config_probe(FW_CONFIG(STORAGE, STORAGE_UFS))) { : printk(BIOS_INFO, "Configure GPIOs, device config for UFS.\n"); : config->add_acpi_dma_property = true; looks like a separate logical change, do you mind splitting this into two patches ?