build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48829 )
Change subject: soc/intel/*: drop UART pad configuration from common code
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48829/4/src/soc/intel/apollolake/ua...
File src/soc/intel/apollolake/uart.c:
https://review.coreboot.org/c/coreboot/+/48829/4/src/soc/intel/apollolake/ua...
PS4, Line 22: #if !CONFIG(SOC_INTEL_GEMINILAKE) // yeah... I don't like it, too ;( will find a better solution
line over 96 characters
https://review.coreboot.org/c/coreboot/+/48829/4/src/soc/intel/apollolake/ua...
PS4, Line 28: #if !CONFIG(SOC_INTEL_GEMINILAKE) // yeah... I don't like it, too ;( will find a better solution
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id03719eb8bd0414083148471ed05dea62a895126
Gerrit-Change-Number: 48829
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Dec 2020 01:39:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment