Change in ...coreboot[master]: autoport: move the generated gnvs.c to acpi_tables.c

[Iru Cai (vimacs) (Code Review)]

Hello Iru Cai,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/30889

to review the following change.

Change subject: autoport: move the generated gnvs.c to acpi_tables.c
......................................................................

autoport: move the generated gnvs.c to acpi_tables.c

Change-Id: I8f6eea579f69060608639b1c50255acd8ab5a4a2
Signed-off-by: Iru Cai 
---
M util/autoport/bd82x6x.go
M util/autoport/main.go
2 files changed, 1 insertion(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/30889/1

diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go
index 887a520..eef0eb7 100644
--- a/util/autoport/bd82x6x.go
+++ b/util/autoport/bd82x6x.go
@@ -391,7 +391,7 @@
    }
    sb.WriteString("}\n")

-	gnvs := Create(ctx, "gnvs.c")
+	gnvs := Create(ctx, "acpi_tables.c")
    defer gnvs.Close()

Add_gpl(gnvs)
@@ -416,7 +416,6 @@
 }
 `)

-	AddRAMStageFile("gnvs.c", "")
 }

func init() {
diff --git a/util/autoport/main.go b/util/autoport/main.go
index ee26966..05a829b 100644
--- a/util/autoport/main.go
+++ b/util/autoport/main.go
@@ -789,10 +789,6 @@
    	}
    }

-	at := Create(ctx, "acpi_tables.c")
-	defer at.Close()
-	at.WriteString("/* dummy */\n")
-
    bi := Create(ctx, "board_info.txt")
    defer bi.Close()

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30889 )

Change subject: autoport: move the generated gnvs.c to acpi_tables.c
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30889 )

Change subject: autoport: move the generated gnvs.c to acpi_tables.c
......................................................................

Patch Set 1: Code-Review+2

[Tristan Corrick (Code Review)]

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30889 )

Change subject: autoport: move the generated gnvs.c to acpi_tables.c
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/30889/1/util/autoport/bd82x6x.go 
File util/autoport/bd82x6x.go:

https://review.coreboot.org/#/c/30889/1/util/autoport/bd82x6x.go@418 
PS1, Line 418: 
It would be good to remove this extra newline too.

[Iru Cai (vimacs) (Code Review)]

Hello Iru Cai, Angel Pons, Arthur Heymans, Tristan Corrick, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/30889

to look at the new patch set (#2).

Change subject: autoport: move the generated gnvs.c to acpi_tables.c
......................................................................

autoport: move the generated gnvs.c to acpi_tables.c

Change-Id: I8f6eea579f69060608639b1c50255acd8ab5a4a2
Signed-off-by: Iru Cai 
---
M util/autoport/bd82x6x.go
M util/autoport/main.go
2 files changed, 1 insertion(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/30889/2

[Iru Cai (vimacs) (Code Review)]

Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30889 )

Change subject: autoport: move the generated gnvs.c to acpi_tables.c
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/30889/1/util/autoport/bd82x6x.go 
File util/autoport/bd82x6x.go:

https://review.coreboot.org/#/c/30889/1/util/autoport/bd82x6x.go@418 
PS1, Line 418:
> It would be good to remove this extra newline too.

Done

[Tristan Corrick (Code Review)]

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30889 )

Change subject: autoport: move the generated gnvs.c to acpi_tables.c
......................................................................

Patch Set 2: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30889 )

Change subject: autoport: move the generated gnvs.c to acpi_tables.c
......................................................................

Patch Set 2: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30889 )

Change subject: autoport: move the generated gnvs.c to acpi_tables.c
......................................................................

autoport: move the generated gnvs.c to acpi_tables.c

Change-Id: I8f6eea579f69060608639b1c50255acd8ab5a4a2
Signed-off-by: Iru Cai 
Reviewed-on: https://review.coreboot.org/c/30889
Tested-by: build bot (Jenkins) 
Reviewed-by: Tristan Corrick 
Reviewed-by: Angel Pons 
---
M util/autoport/bd82x6x.go
M util/autoport/main.go
2 files changed, 1 insertion(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tristan Corrick: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go
index 887a520..29b1c21 100644
--- a/util/autoport/bd82x6x.go
+++ b/util/autoport/bd82x6x.go
@@ -391,7 +391,7 @@
    }
    sb.WriteString("}\n")

-	gnvs := Create(ctx, "gnvs.c")
+	gnvs := Create(ctx, "acpi_tables.c")
    defer gnvs.Close()

Add_gpl(gnvs)
@@ -415,8 +415,6 @@
    gnvs->tpsv = 90;
 }
 `)
-
-	AddRAMStageFile("gnvs.c", "")
 }

func init() {
diff --git a/util/autoport/main.go b/util/autoport/main.go
index ee26966..05a829b 100644
--- a/util/autoport/main.go
+++ b/util/autoport/main.go
@@ -789,10 +789,6 @@
    	}
    }

-	at := Create(ctx, "acpi_tables.c")
-	defer at.Close()
-	at.WriteString("/* dummy */\n")
-
    bi := Create(ctx, "board_info.txt")
    defer bi.Close()