[S] Change in coreboot[master]: mb/google/brya/var/gaelin: Configure audio in devicetree - coreboot-gerrit

30 Nov 2022


      Attention is currently required from: Tarun Tuli, Raymond Chung, Paul Menzel, Zhuohao Lee.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69964 )
Change subject: mb/google/brya/var/gaelin: Configure audio in devicetree
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/mainboard/google/brya/variants/gaelin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/69964/comment/55fef93b_3a487bbf 
PS3, Line 239: 		device ref hda on
...
Yes, it requires hda to be turned on. Otherwise ALC1015 cannot work normally.
you are right, it's not for soundwire only. hda is on in baseboard but we need to register device here.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69964
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc8cacce6cb4b3e55fc7332bb9eb9ac20848fc5b
Gerrit-Change-Number: 69964
Gerrit-PatchSet: 3
Gerrit-Owner: Raymond Chung raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Derek Huang derekhuang@google.com
Gerrit-Reviewer: Raymond Chung raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Bruce Chiang brucechiang@msi.corp-partner.google.com
Gerrit-CC: Eason Chang easonchang@msi.corp-partner.google.com
Gerrit-CC: Eddy Lu eddylu@ami.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Raymond Chung raymondchung@ami.corp-partner.google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Zhuohao Lee zhuohao@google.com
Gerrit-Comment-Date: Wed, 30 Nov 2022 11:15:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raymond Chung raymondchung@ami.corp-partner.google.com
Comment-In-Reply-To: Derek Huang derekhuang@google.com
Gerrit-MessageType: comment