Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31530 )
Change subject: drivers/intel/fsp2_0: Update dependency of USE_FSP_REPO
......................................................................
Patch Set 3: Code-Review+1
I agree to the change, but just realized that the description
of SOC_INTEL_COMMON_CANNONLAKE_BASE doesn't make much sense
any more, does it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31530
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e5d5a9fdf3f5d3e79922e97719e8491aa514cef
Gerrit-Change-Number: 31530
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 23 Feb 2019 10:46:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment