Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33953 )
Change subject: mb/google/hatch/variants/helios: Update SPD sources
......................................................................
Patch Set 2:
Patch Set 1:
Patch Set 1: Code-Review-1
(1 comment)
The DRAM ID table at Proto stage is
ID 0 Samsung 16Gb 2133MT/s K4E6E304EC/ED-EGCG
ID 1 Samsung 32Gb 2133MT/s K4EB304ED-EGCG
ID 2 Hynix 8Gb 2133MT/s H9CCNNN8GTALAR-NVD
ID 3 Hynix 16Gb 2133MT/s H9CCNNNBJTALAR-NVD
ID 4 Hynix 32Gb 2133MT/s H9CCNNNCLGALAR-NVD
According to Intel's feedback , current SPD support the same capacity and speed with different brand , so ID 0 and ID 3 use 1 SPD file . ID 1 and ID 4 use another SPD file .
No, this is not correct. Can you please raise a bug for discussing this? I think there is some confusion here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33953
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cb4e46c7c4da72d8fb029f1b8e8c3b06d1ab156
Gerrit-Change-Number: 33953
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Jul 2019 14:23:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment