Gabe Black (gabeblack@chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3742
-gerrit
commit 763c146c80b3370d616d4b20de9f2f1a9f164d79 Author: Duncan Laurie dlaurie@chromium.org Date: Tue May 21 07:49:11 2013 -0700
ec: Remove hardcoded GPI offset in EC SCI
With LynxPoint-LP the SCI GPE is no longer a GPIO that is offset by 16. Remove the Add and fix up the link definition so it is still accurate.
Change-Id: I091141183a09345b5ffe28365583e48019f9f5e5 Signed-off-by: Duncan Laurie dlaurie@chromium.org --- src/ec/google/chromeec/acpi/ec.asl | 2 +- src/mainboard/google/link/ec.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 2fb8e79..cb196a7 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -27,7 +27,7 @@ Device (EC0) { Name (_HID, EISAID ("PNP0C09")) Name (_UID, 1) - Name (_GPE, Add(EC_SCI_GPI, 16)) + Name (_GPE, EC_SCI_GPI) Name (TOFS, EC_TEMP_SENSOR_OFFSET) Name (TNOP, 0xFD) // Thermal sensor has no power Name (TBAD, 0xFE) // Thermal sensor bad reading diff --git a/src/mainboard/google/link/ec.h b/src/mainboard/google/link/ec.h index 6133f97..0044347 100644 --- a/src/mainboard/google/link/ec.h +++ b/src/mainboard/google/link/ec.h @@ -22,7 +22,7 @@
#include <ec/google/chromeec/ec_commands.h>
-#define EC_SCI_GPI 7 /* GPIO7 is EC_SCI# */ +#define EC_SCI_GPI 23 /* GPIO7/GPE23 is EC_SCI# */ #define EC_SMI_GPI 8 /* GPIO8 is EC_SMI# */
#define LINK_EC_SCI_EVENTS \