Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Amanda Hwang has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/82661?usp=email )
Change subject: mb/google/trulo/var/orisa: Configure GPIO settings
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/orisa/gpio.c:
https://review.coreboot.org/c/coreboot/+/82661/comment/ab76d0d3_03c02901?usp... :
PS3, Line 437: PAD_CFG_GPO_LOCK(GPP_E17, 1, LOCK_CONFIG),
there is no point of using `LOCK` macro prior to ramstage as it won't lock anything. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82661?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I760a7a234df43db3a557b3be9e20ff7aa5f80b72
Gerrit-Change-Number: 82661
Gerrit-PatchSet: 4
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 13 Jun 2024 02:55:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com