Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45569 )
Change subject: drivers/tpm/ppi_stub: Fix interface version ......................................................................
drivers/tpm/ppi_stub: Fix interface version
The latest version defined by Tcg is 1.3.
Change-Id: Idb12e2212d6d38c720c8fe989678724c871af6ef Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/tpm/ppi_stub.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/45569/1
diff --git a/src/drivers/tpm/ppi_stub.c b/src/drivers/tpm/ppi_stub.c index a4b8f57..a5d0252 100644 --- a/src/drivers/tpm/ppi_stub.c +++ b/src/drivers/tpm/ppi_stub.c @@ -20,7 +20,7 @@ { if (CONFIG(TPM2)) /* Interface version: 2.0 */ - acpigen_write_return_string("2.0"); + acpigen_write_return_string("1.3"); else /* Interface version: 1.2 */ acpigen_write_return_string("1.2");
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45569 )
Change subject: drivers/tpm/ppi_stub: Fix interface version ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45569/4/src/drivers/tpm/ppi_stub.c File src/drivers/tpm/ppi_stub.c:
https://review.coreboot.org/c/coreboot/+/45569/4/src/drivers/tpm/ppi_stub.c@... PS4, Line 22: 2.0 1.3?
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45569
to look at the new patch set (#5).
Change subject: drivers/tpm/ppi_stub: Fix interface version ......................................................................
drivers/tpm/ppi_stub: Fix interface version
The latest version defined by Tcg is 1.3.
Change-Id: Idb12e2212d6d38c720c8fe989678724c871af6ef Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/tpm/ppi_stub.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/45569/5
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45569 )
Change subject: drivers/tpm/ppi_stub: Fix interface version ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45569/4/src/drivers/tpm/ppi_stub.c File src/drivers/tpm/ppi_stub.c:
https://review.coreboot.org/c/coreboot/+/45569/4/src/drivers/tpm/ppi_stub.c@... PS4, Line 22: 2.0
- […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45569 )
Change subject: drivers/tpm/ppi_stub: Fix interface version ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45569/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45569/5//COMMIT_MSG@9 PS5, Line 9: Tcg nit: TCG
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45569
to look at the new patch set (#6).
Change subject: drivers/tpm/ppi_stub: Fix interface version ......................................................................
drivers/tpm/ppi_stub: Fix interface version
The latest version defined by TCG is 1.3.
Change-Id: Idb12e2212d6d38c720c8fe989678724c871af6ef Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/tpm/ppi_stub.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/45569/6
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45569 )
Change subject: drivers/tpm/ppi_stub: Fix interface version ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45569/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45569/5//COMMIT_MSG@9 PS5, Line 9: Tcg
nit: TCG
Done
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45569 )
Change subject: drivers/tpm/ppi_stub: Fix interface version ......................................................................
Patch Set 6: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45569 )
Change subject: drivers/tpm/ppi_stub: Fix interface version ......................................................................
drivers/tpm/ppi_stub: Fix interface version
The latest version defined by TCG is 1.3.
Change-Id: Idb12e2212d6d38c720c8fe989678724c871af6ef Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45569 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/tpm/ppi_stub.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/drivers/tpm/ppi_stub.c b/src/drivers/tpm/ppi_stub.c index 11bd07e..1e3a7fc 100644 --- a/src/drivers/tpm/ppi_stub.c +++ b/src/drivers/tpm/ppi_stub.c @@ -18,8 +18,8 @@ static void tpm_ppi_func1_cb(void *arg) { if (CONFIG(TPM2)) - /* Interface version: 2.0 */ - acpigen_write_return_string("2.0"); + /* Interface version: 1.3 */ + acpigen_write_return_string("1.3"); else /* Interface version: 1.2 */ acpigen_write_return_string("1.2");
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Hung-Te Lin (Code Review)
-
Patrick Rudolph (Code Review)