Change in coreboot[master]: mb/system76/lemp9: use absolute path for _GPE

List overview All Threads
Download

newer

older

Change in coreboot[master]: mb:...

Change in coreboot[master]:...

Jeremy Soller (Code Review)

20 Jul 2020 20 Jul '20

11:32 p.m.

Jeremy Soller has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43630 )

Change subject: mb/system76/lemp9: use absolute path for _GPE ......................................................................

mb/system76/lemp9: use absolute path for _GPE

_GPE cannot be anywhere but at the root of the ACPI namespace.

This change ensures that is always the case.

Tested on lemp9, GPE still in correct location

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Ib31683b06e61da4b1859cd939c36879cebf4c03c --- M src/mainboard/system76/lemp9/acpi/mainboard.asl 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/43630/1

diff --git a/src/mainboard/system76/lemp9/acpi/mainboard.asl b/src/mainboard/system76/lemp9/acpi/mainboard.asl index 4e8691d..dfa81d3 100644 --- a/src/mainboard/system76/lemp9/acpi/mainboard.asl +++ b/src/mainboard/system76/lemp9/acpi/mainboard.asl @@ -9,6 +9,6 @@ #include "sleep.asl" }

-Scope (_GPE) { +Scope (_GPE) { #include "gpe.asl" }

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Jeremy Soller (Code Review)

21 Jul 21 Jul

12:02 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43630

to look at the new patch set (#7).

Change subject: mb/system76/lemp9: use absolute path for _GPE ......................................................................

mb/system76/lemp9: use absolute path for _GPE

_GPE cannot be anywhere but at the root of the ACPI namespace.

This change ensures that is always the case.

Tested on lemp9, GPE still in correct location

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/43630/7

Angel Pons (Code Review)

12:04 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43630 )

Change subject: mb/system76/lemp9: use absolute path for _GPE ......................................................................

Patch Set 7: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43630/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43630/7//COMMIT_MSG@13 PS7, Line 13: Tested on lemp9, GPE still in correct location Please add a period at the end of the sentence.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib31683b06e61da4b1859cd939c36879cebf4c03c Gerrit-Change-Number: 43630 Gerrit-PatchSet: 7 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 20 Jul 2020 22:04:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jeremy Soller (Code Review)

12:11 a.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43630

to look at the new patch set (#8).

Change subject: mb/system76/lemp9: use absolute path for _GPE ......................................................................

mb/system76/lemp9: use absolute path for _GPE

_GPE cannot be anywhere but at the root of the ACPI namespace.

This change ensures that is always the case.

Tested on lemp9, GPE still in correct location.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/43630/8

Jeremy Soller (Code Review)

4:20 p.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43630

to look at the new patch set (#12).

Change subject: mb/system76/lemp9: use absolute path for _GPE ......................................................................

mb/system76/lemp9: use absolute path for _GPE

_GPE cannot be anywhere but at the root of the ACPI namespace.

This change ensures that is always the case.

Tested on lemp9, GPE still in correct location.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/43630/12

Jeremy Soller (Code Review)

22 Jul 22 Jul

2:45 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43630

to look at the new patch set (#16).

Change subject: mb/system76/lemp9: use absolute path for _GPE ......................................................................

mb/system76/lemp9: use absolute path for _GPE

_GPE cannot be anywhere but at the root of the ACPI namespace.

This change ensures that is always the case.

Tested on lemp9, GPE still in correct location.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/43630/16

Jeremy Soller (Code Review)

4:09 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43630

to look at the new patch set (#18).

Change subject: mb/system76/lemp9: use absolute path for _GPE ......................................................................

mb/system76/lemp9: use absolute path for _GPE

_GPE cannot be anywhere but at the root of the ACPI namespace.

This change ensures that is always the case.

Tested on lemp9, GPE still in correct location.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/43630/18

Christian Walter (Code Review)

5:17 p.m.

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43630 )

Change subject: mb/system76/lemp9: use absolute path for _GPE ......................................................................

Patch Set 18: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib31683b06e61da4b1859cd939c36879cebf4c03c Gerrit-Change-Number: 43630 Gerrit-PatchSet: 18 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 22 Jul 2020 15:17:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

31 Aug 31 Aug

1:06 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43630 )

Change subject: mb/system76/lemp9: use absolute path for _GPE ......................................................................

Patch Set 19: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib31683b06e61da4b1859cd939c36879cebf4c03c Gerrit-Change-Number: 43630 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 30 Aug 2020 23:06:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Singer (Code Review)

6 Sep 6 Sep

2:04 a.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Use absolute path for _GPE

Felix Singer has uploaded a new patch set (#20) to the change originally created by Jeremy Soller. ( https://review.coreboot.org/c/coreboot/+/43630 )

Change subject: mb/system76/lemp9: Use absolute path for _GPE ......................................................................

mb/system76/lemp9: Use absolute path for _GPE

_GPE cannot be anywhere but at the root of the ACPI namespace.

This change ensures that is always the case.

Tested on lemp9, GPE still in correct location.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/43630/20

-- To view, visit https://review.coreboot.org/c/coreboot/+/43630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib31683b06e61da4b1859cd939c36879cebf4c03c Gerrit-Change-Number: 43630 Gerrit-PatchSet: 20 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

2:15 a.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Use absolute path for _GPE

Felix Singer has uploaded a new patch set (#21) to the change originally created by Jeremy Soller. ( https://review.coreboot.org/c/coreboot/+/43630 )

Change subject: mb/system76/lemp9: Use absolute path for _GPE ......................................................................

mb/system76/lemp9: Use absolute path for _GPE

_GPE cannot be anywhere but at the root of the ACPI namespace.

This change ensures that is always the case.

Tested on lemp9, GPE still in correct location.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/43630/21

-- To view, visit https://review.coreboot.org/c/coreboot/+/43630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib31683b06e61da4b1859cd939c36879cebf4c03c Gerrit-Change-Number: 43630 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

2:16 a.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Use absolute path for _GPE

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43630 )

Change subject: mb/system76/lemp9: Use absolute path for _GPE ......................................................................

Patch Set 21: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/43630/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43630/7//COMMIT_MSG@13 PS7, Line 13: Tested on lemp9, GPE still in correct location

...

Please add a period at the end of the sentence.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib31683b06e61da4b1859cd939c36879cebf4c03c Gerrit-Change-Number: 43630 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 06 Sep 2020 00:16:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

4:41 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Use absolute path for _GPE

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43630 )

Change subject: mb/system76/lemp9: Use absolute path for _GPE ......................................................................

Patch Set 21: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib31683b06e61da4b1859cd939c36879cebf4c03c Gerrit-Change-Number: 43630 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 06 Sep 2020 14:41:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

4:41 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Use absolute path for _GPE

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43630 )

Change subject: mb/system76/lemp9: Use absolute path for _GPE ......................................................................

mb/system76/lemp9: Use absolute path for _GPE

_GPE cannot be anywhere but at the root of the ACPI namespace.

This change ensures that is always the case.

Tested on lemp9, GPE still in correct location.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Ib31683b06e61da4b1859cd939c36879cebf4c03c Reviewed-on: https://review.coreboot.org/c/coreboot/+/43630 Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/system76/lemp9/acpi/mainboard.asl 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Michael Niewöhner: Looks good to me, approved

-Scope (_GPE) { +Scope (_GPE) { #include "gpe.asl" }

-- To view, visit https://review.coreboot.org/c/coreboot/+/43630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib31683b06e61da4b1859cd939c36879cebf4c03c Gerrit-Change-Number: 43630 Gerrit-PatchSet: 22 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1539

days inactive

1587

days old

coreboot-gerrit@coreboot.org

13 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Christian Walter (Code Review)
Felix Singer (Code Review)
Jeremy Soller (Code Review)
Michael Niewöhner (Code Review)